Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-10 Thread Mark yao
On 2015年12月02日 22:18, Daniel Stone wrote: Hi Mark, Thanks for getting back to this. On 1 December 2015 at 09:31, Mark yao wrote: On 2015年12月01日 16:18, Daniel Stone wrote: On 1 December 2015 at 03:26, Mark Yao wrote: + for_each_crtc_in_state(state, crtc, crtc_state, i) { +

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-10 Thread Mark yao
On 2015年12月02日 22:18, Daniel Stone wrote: Hi Mark, Thanks for getting back to this. On 1 December 2015 at 09:31, Mark yao wrote: On 2015年12月01日 16:18, Daniel Stone wrote: On 1 December 2015 at 03:26, Mark Yao wrote: +

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-02 Thread Daniel Stone
Hi Mark, On 2 December 2015 at 14:18, Daniel Stone wrote: > On 1 December 2015 at 09:31, Mark yao wrote: >> Can you share your Weston environment to me, I'm interesting to test drm >> rockchip on weston. > > Of course. You can download Weston from http://wayland.freedesktop.org > - the most

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-02 Thread Daniel Stone
Hi Mark, Thanks for getting back to this. On 1 December 2015 at 09:31, Mark yao wrote: > On 2015年12月01日 16:18, Daniel Stone wrote: >> On 1 December 2015 at 03:26, Mark Yao wrote: >>> >+ for_each_crtc_in_state(state, crtc, crtc_state, i) { >>> >+ if (!crtc->state->active) >>>

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-02 Thread Daniel Stone
Hi Mark, On 2 December 2015 at 14:18, Daniel Stone wrote: > On 1 December 2015 at 09:31, Mark yao wrote: >> Can you share your Weston environment to me, I'm interesting to test drm >> rockchip on weston. > > Of course. You can download Weston

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-02 Thread Daniel Stone
Hi Mark, Thanks for getting back to this. On 1 December 2015 at 09:31, Mark yao wrote: > On 2015年12月01日 16:18, Daniel Stone wrote: >> On 1 December 2015 at 03:26, Mark Yao wrote: >>> >+ for_each_crtc_in_state(state, crtc, crtc_state, i) {

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-01 Thread Mark yao
On 2015年12月01日 16:18, Daniel Stone wrote: Hi Mark, On 1 December 2015 at 03:26, Mark Yao wrote: >+static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) >+{ >+ struct drm_crtc_state *crtc_state; >+ struct drm_crtc *crtc; >+ int i; >+ >+

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-01 Thread Mark yao
On 2015年12月01日 16:18, Daniel Stone wrote: Hi Mark, On 1 December 2015 at 03:26, Mark Yao wrote: +static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) +{ + struct drm_crtc_state *crtc_state; + struct drm_crtc *crtc; + int i; + +

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-01 Thread Daniel Stone
Hi Mark, On 1 December 2015 at 03:26, Mark Yao wrote: > +static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) > +{ > + struct drm_crtc_state *crtc_state; > + struct drm_crtc *crtc; > + int i; > + > + for_each_crtc_in_state(state, crtc, crtc_state,

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-01 Thread Mark yao
On 2015年12月01日 16:18, Daniel Stone wrote: Hi Mark, On 1 December 2015 at 03:26, Mark Yao wrote: +static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) +{ + struct drm_crtc_state *crtc_state; + struct drm_crtc *crtc; + int i; +

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-01 Thread Mark yao
On 2015年12月01日 16:18, Daniel Stone wrote: Hi Mark, On 1 December 2015 at 03:26, Mark Yao wrote: >+static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) >+{ >+ struct drm_crtc_state *crtc_state; >+ struct drm_crtc *crtc; >+ int

Re: [RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-12-01 Thread Daniel Stone
Hi Mark, On 1 December 2015 at 03:26, Mark Yao wrote: > +static void rockchip_atomic_wait_for_complete(struct drm_atomic_state *state) > +{ > + struct drm_crtc_state *crtc_state; > + struct drm_crtc *crtc; > + int i; > + > +

[RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-11-30 Thread Mark Yao
Rockchip vop not support hw vblank counter, needed check the committed register if it's really take effect. Signed-off-by: Mark Yao Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c |5 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.h |2 +

[RFC PATCH 3/9] drm/rockchip: Convert to support atomic API

2015-11-30 Thread Mark Yao
Rockchip vop not support hw vblank counter, needed check the committed register if it's really take effect. Signed-off-by: Mark Yao Signed-off-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c |5 +-