Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-30 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 01:44:52PM -0400, Trond Myklebust wrote: > > Which is exactly that problem this tries to solve. Once you have > > union mounts you'll have a single open file descriptor for multiple > > actual directories. Beause of that you can't simply attach to the > > state to the str

Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-20 Thread Trond Myklebust
On Wed, 2007-06-20 at 18:02 +0100, Christoph Hellwig wrote: > On Wed, Jun 20, 2007 at 10:22:28AM -0400, Trond Myklebust wrote: > > No it shouldn't. The struct file contains other stateful information > > from the open() call (such as authentication info) that needs to be > > passed into readdir. >

Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 10:22:28AM -0400, Trond Myklebust wrote: > No it shouldn't. The struct file contains other stateful information > from the open() call (such as authentication info) that needs to be > passed into readdir. Which is exactly that problem this tries to solve. Once you have uni

Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-20 Thread Trond Myklebust
On Wed, 2007-06-20 at 13:09 +0100, Christoph Hellwig wrote: > On Wed, Jun 20, 2007 at 11:24:18AM +0530, Bharata B Rao wrote: > > From: Bharata B Rao <[EMAIL PROTECTED]> > > Subject: Directory listing support for union mounted directories. > > > > Modifies readdir()/getdents() to support union moun

Re: [RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-20 Thread Christoph Hellwig
On Wed, Jun 20, 2007 at 11:24:18AM +0530, Bharata B Rao wrote: > From: Bharata B Rao <[EMAIL PROTECTED]> > Subject: Directory listing support for union mounted directories. > > Modifies readdir()/getdents() to support union mounted directories. > > This patch adds support to readdir()/getdents()

[RFC PATCH 4/4] Directory listing support for union mounted directories.

2007-06-19 Thread Bharata B Rao
From: Bharata B Rao <[EMAIL PROTECTED]> Subject: Directory listing support for union mounted directories. Modifies readdir()/getdents() to support union mounted directories. This patch adds support to readdir()/getdents() to read directory entries from all the directories of the union stack, and