Re: [RFC PATCH 4/4] crypto: Add EC-RDSA algorithm

2019-01-16 Thread David Howells
Vitaly Chikunov wrote: > > Regarding your comment (2), I am not sure I understand. Why do you say that > > the DER format cannot be parsed by the kernel's ASN.1 parser? For example, > > It can, but DER is stricter than BER. For example, in DER 'OCTET STRING' > length field should be encoded

Re: [RFC PATCH 4/4] crypto: Add EC-RDSA algorithm

2019-01-07 Thread Vitaly Chikunov
Stephan, On Mon, Jan 07, 2019 at 09:31:40AM +0100, Stephan Mueller wrote: > Am Montag, 7. Januar 2019, 09:07:10 CET schrieb Vitaly Chikunov: > > > > Why do you manually parse the ASN.1 structure instead of using the ASN.1 > > > parser? > > > > I am not sure this worth effort and will not be

Re: [RFC PATCH 4/4] crypto: Add EC-RDSA algorithm

2019-01-07 Thread Stephan Mueller
Am Montag, 7. Januar 2019, 09:07:10 CET schrieb Vitaly Chikunov: Hi Vitaly, > > Why do you manually parse the ASN.1 structure instead of using the ASN.1 > > parser? > > I am not sure this worth effort and will not be most degenerate use of > asn1_ber_decoder, since 1) I only need to parse one

Re: [RFC PATCH 4/4] crypto: Add EC-RDSA algorithm

2019-01-07 Thread Vitaly Chikunov
Stephan, On Sun, Jan 06, 2019 at 07:11:50PM +0100, Stephan Müller wrote: > Am Sonntag, 6. Januar 2019, 14:36:08 CET schrieb Vitaly Chikunov: > > > Add Elliptic Curve Russian Digital Signature Algorithm (GOST R > > 34.10-2012, RFC 7091, ISO/IEC 14888-3) is one of the Russian (and since > > 2018

Re: [RFC PATCH 4/4] crypto: Add EC-RDSA algorithm

2019-01-06 Thread Stephan Müller
Am Sonntag, 6. Januar 2019, 14:36:08 CET schrieb Vitaly Chikunov: Hi Vitaly, > Add Elliptic Curve Russian Digital Signature Algorithm (GOST R > 34.10-2012, RFC 7091, ISO/IEC 14888-3) is one of the Russian (and since > 2018 the CIS countries) cryptographic standard algorithms (called GOST >

[RFC PATCH 4/4] crypto: Add EC-RDSA algorithm

2019-01-06 Thread Vitaly Chikunov
Add Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012, RFC 7091, ISO/IEC 14888-3) is one of the Russian (and since 2018 the CIS countries) cryptographic standard algorithms (called GOST algorithms). Only signature verification is supported, with intent to be used in the IMA.