Re: [RFC PATCH 5/6] ethernet: dfl-eth-group: add DFL eth group private feature driver

2020-10-25 Thread Andrew Lunn
> > +u64 read_mac_stats(struct eth_com *ecom, unsigned int addr) > > +{ > > + u32 data_l, data_h; > > + > > + if (eth_com_read_reg(ecom, addr, _l) || > > + eth_com_read_reg(ecom, addr + 1, _h)) > > + return 0xULL; > return -1; ? Since this is a u64 function, i

Re: [RFC PATCH 5/6] ethernet: dfl-eth-group: add DFL eth group private feature driver

2020-10-24 Thread Tom Rix
On 10/23/20 1:45 AM, Xu Yilun wrote: > This driver supports the DFL Ether Group private feature for the Intel(R) > PAC N3000 FPGA Smart NIC. > > The DFL Ether Group private feature contains an Ether Wrapper and several > ports (phy-mac pair). There are two types of Ether Groups, line side &

Re: [RFC PATCH 5/6] ethernet: dfl-eth-group: add DFL eth group private feature driver

2020-10-24 Thread Andrew Lunn
> +++ b/Documentation/ABI/testing/sysfs-class-net-dfl-eth-group > @@ -0,0 +1,19 @@ > +What:/sys/class/net//tx_pause_frame_quanta > +Date:Oct 2020 > +KernelVersion: 5.11 > +Contact: Xu Yilun > +Description: > + Read-Write. Value representing

[RFC PATCH 5/6] ethernet: dfl-eth-group: add DFL eth group private feature driver

2020-10-23 Thread Xu Yilun
This driver supports the DFL Ether Group private feature for the Intel(R) PAC N3000 FPGA Smart NIC. The DFL Ether Group private feature contains an Ether Wrapper and several ports (phy-mac pair). There are two types of Ether Groups, line side & host side. These 2 types of Ether Groups, together