Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Sun, Sep 14, 2014 at 09:14:04PM -0700, Grant Likely wrote: > On Mon, 01 Sep 2014 19:11:44 +0200, Arnd Bergmann wrote: > > > > + config->phy_interface = PHY_INTERFACE_MODE_MII; > > > > + config->flags |= SMSC911X_USE_32BIT; > > > > + config->irq_polarity =

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 15, 2014 at 05:08:44AM +0100, Grant Likely wrote: > On Mon, 1 Sep 2014 16:28:54 +0100, Graeme Gregory > wrote: > > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: > > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > > > > +#ifdef CONFIG_ACPI > > > > +/*

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 15, 2014 at 05:08:44AM +0100, Grant Likely wrote: On Mon, 1 Sep 2014 16:28:54 +0100, Graeme Gregory graeme.greg...@linaro.org wrote: On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: +#ifdef CONFIG_ACPI

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Sun, Sep 14, 2014 at 09:14:04PM -0700, Grant Likely wrote: On Mon, 01 Sep 2014 19:11:44 +0200, Arnd Bergmann a...@arndb.de wrote: + config-phy_interface = PHY_INTERFACE_MODE_MII; + config-flags |= SMSC911X_USE_32BIT; + config-irq_polarity =

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, 01 Sep 2014 19:11:44 +0200, Arnd Bergmann wrote: > On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: > > On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: > > > +#ifdef CONFIG_ACPI > > > +/* Configure some sensible defaults for ACPI mode */ > > > +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, 1 Sep 2014 16:28:54 +0100, Graeme Gregory wrote: > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > > > +#ifdef CONFIG_ACPI > > > +/* Configure some sensible defaults for ACPI mode */ > > > +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, 1 Sep 2014 16:28:54 +0100, Graeme Gregory graeme.greg...@linaro.org wrote: On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, 01 Sep 2014 19:11:44 +0200, Arnd Bergmann a...@arndb.de wrote: On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

Hi Arnd, On 09/03/2014 11:09 AM, Arnd Bergmann wrote: > On Wednesday 03 September 2014 01:00:23 Rafael J. Wysocki wrote: >> Our intention is specifically not to use "random incompatible bindings" >> in that. We'd rather have a common venue and process for establishing >> new bindings for both

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

Hi Arnd, On 09/03/2014 11:09 AM, Arnd Bergmann wrote: On Wednesday 03 September 2014 01:00:23 Rafael J. Wysocki wrote: Our intention is specifically not to use random incompatible bindings in that. We'd rather have a common venue and process for establishing new bindings for both DT and

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Wednesday 03 September 2014 01:00:23 Rafael J. Wysocki wrote: > On Tuesday, September 02, 2014 05:26:06 PM Mark Brown wrote: > > > > --s3puAW9DMBtS2ARW > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > > > On Tue, Sep 02, 2014 at 03:42:53PM +0200, Arnd

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Wednesday 03 September 2014 01:00:23 Rafael J. Wysocki wrote: On Tuesday, September 02, 2014 05:26:06 PM Mark Brown wrote: --s3puAW9DMBtS2ARW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 02, 2014 at 03:42:53PM +0200, Arnd Bergmann wrote:

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Tuesday, September 02, 2014 05:26:06 PM Mark Brown wrote: > > --s3puAW9DMBtS2ARW > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > On Tue, Sep 02, 2014 at 03:42:53PM +0200, Arnd Bergmann wrote: > > > The way I recall the discussion, most people were on one

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Tue, Sep 02, 2014 at 03:42:53PM +0200, Arnd Bergmann wrote: > The way I recall the discussion, most people were on one extreme > side of the discussion or the other: > a) We should use _DSD for ARM64 servers to maximize code reuse with > DT-enabled drivers, work around the slow UEFI

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Tuesday 02 September 2014 14:26:52 Catalin Marinas wrote: > > Not much at the KS, I think it will need to be followed up on lkml > (https://lkml.org/lkml/2014/8/17/10 is the last I'm aware of, not sure > about any updates in the meantime). > > While the above gets sorted, what's the position

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:32:45PM +0100, Graeme Gregory wrote: > On Mon, Sep 01, 2014 at 07:11:44PM +0200, Arnd Bergmann wrote: > > On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: > > > On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: > > > > +#ifdef CONFIG_ACPI > > > > +/*

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:32:45PM +0100, Graeme Gregory wrote: On Mon, Sep 01, 2014 at 07:11:44PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Tuesday 02 September 2014 14:26:52 Catalin Marinas wrote: Not much at the KS, I think it will need to be followed up on lkml (https://lkml.org/lkml/2014/8/17/10 is the last I'm aware of, not sure about any updates in the meantime). While the above gets sorted, what's the position from

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Tue, Sep 02, 2014 at 03:42:53PM +0200, Arnd Bergmann wrote: The way I recall the discussion, most people were on one extreme side of the discussion or the other: a) We should use _DSD for ARM64 servers to maximize code reuse with DT-enabled drivers, work around the slow UEFI

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Tuesday, September 02, 2014 05:26:06 PM Mark Brown wrote: --s3puAW9DMBtS2ARW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 02, 2014 at 03:42:53PM +0200, Arnd Bergmann wrote: The way I recall the discussion, most people were on one extreme side

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:32:45PM +0100, Graeme Gregory wrote: > This will of course most likely be replaced by _DSD values. I just > hardcoded for now as _DSD is not yet in the kernel and issues around > maintenance of bindings are not solved (unless this happened at KS where > I was not

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 07:11:44PM +0200, Arnd Bergmann wrote: > On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: > > On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: > > > +#ifdef CONFIG_ACPI > > > +/* Configure some sensible defaults for ACPI mode */ > > > +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On 01/09/14 18:14, Catalin Marinas wrote: On Mon, Sep 01, 2014 at 06:08:49PM +0100, Sudeep Holla wrote: On 01/09/14 17:58, Mark Brown wrote: On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: Confused. Then how come smsc911x_drv_probe() has this line: acpi_handle

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:11:44PM +0100, Arnd Bergmann wrote: > On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: > > On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: > > > +#ifdef CONFIG_ACPI > > > +/* Configure some sensible defaults for ACPI mode */ > > > +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:08:49PM +0100, Sudeep Holla wrote: > On 01/09/14 17:58, Mark Brown wrote: > > On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: > > > >> Confused. Then how come smsc911x_drv_probe() has this line: > > > >>acpi_handle *ahandle = ACPI_HANDLE(>dev); > > >

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: > On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: > > +#ifdef CONFIG_ACPI > > +/* Configure some sensible defaults for ACPI mode */ > > +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config > > *config, > > +

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

Hi Mark, On 01/09/14 17:58, Mark Brown wrote: On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: Confused. Then how come smsc911x_drv_probe() has this line: acpi_handle *ahandle = ACPI_HANDLE(>dev); without any #ifdef's. There's a stub

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: > +#ifdef CONFIG_ACPI > +/* Configure some sensible defaults for ACPI mode */ > +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config > *config, > + acpi_handle *ahandle) > +{ > + if

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: > On Mon, Sep 01, 2014 at 04:28:54PM +0100, Graeme Gregory wrote: > > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: > > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > > > > +#ifdef CONFIG_ACPI > > > > +/*

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: > Confused. Then how come smsc911x_drv_probe() has this line: > acpi_handle *ahandle = ACPI_HANDLE(>dev); > without any #ifdef's. There's a stub smsc911x_probe_config_acpi() provided in the non-ACPI case, Arnd's suggestion

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 04:28:54PM +0100, Graeme Gregory wrote: > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > > > +#ifdef CONFIG_ACPI > > > +/* Configure some sensible defaults for ACPI mode */ > > > +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Monday 01 September 2014 16:28:54 Graeme Gregory wrote: > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > > > +#ifdef CONFIG_ACPI > > > +/* Configure some sensible defaults for ACPI mode */ > > > +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > > +#ifdef CONFIG_ACPI > > +/* Configure some sensible defaults for ACPI mode */ > > +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config > > *config, > > +

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > +#ifdef CONFIG_ACPI > +/* Configure some sensible defaults for ACPI mode */ > +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config > *config, > + acpi_handle *ahandle) > +{ > + if

[RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

From: Graeme Gregory This is a standard platform device to resources are converted in the ACPI core in the same fasion as DT resources. For the other DT provided information there is _DSD for ACPI. Signed-off-by: Graeme Gregory --- drivers/net/ethernet/smsc/smsc911x.c | 38

[RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

From: Graeme Gregory graeme.greg...@linaro.org This is a standard platform device to resources are converted in the ACPI core in the same fasion as DT resources. For the other DT provided information there is _DSD for ACPI. Signed-off-by: Graeme Gregory graeme.greg...@linaro.org ---

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config, + acpi_handle *ahandle) +{ + if

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config, +

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Monday 01 September 2014 16:28:54 Graeme Gregory wrote: On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 04:28:54PM +0100, Graeme Gregory wrote: On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: Confused. Then how come smsc911x_drv_probe() has this line: acpi_handle *ahandle = ACPI_HANDLE(pdev-dev); without any #ifdef's. There's a stub smsc911x_probe_config_acpi() provided in the non-ACPI case, Arnd's suggestion

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: On Mon, Sep 01, 2014 at 04:28:54PM +0100, Graeme Gregory wrote: On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config, + acpi_handle *ahandle) +{ + if

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

Hi Mark, On 01/09/14 17:58, Mark Brown wrote: On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: Confused. Then how come smsc911x_drv_probe() has this line: acpi_handle *ahandle = ACPI_HANDLE(pdev-dev); without any #ifdef's. There's a stub

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config, +

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:08:49PM +0100, Sudeep Holla wrote: On 01/09/14 17:58, Mark Brown wrote: On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: Confused. Then how come smsc911x_drv_probe() has this line: acpi_handle *ahandle = ACPI_HANDLE(pdev-dev); without

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:11:44PM +0100, Arnd Bergmann wrote: On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int

Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On 01/09/14 18:14, Catalin Marinas wrote: On Mon, Sep 01, 2014 at 06:08:49PM +0100, Sudeep Holla wrote: On 01/09/14 17:58, Mark Brown wrote: On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: Confused. Then how come smsc911x_drv_probe() has this line: acpi_handle

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 07:11:44PM +0200, Arnd Bergmann wrote: On Monday 01 September 2014 18:04:47 Catalin Marinas wrote: On Mon, Sep 01, 2014 at 04:06:00PM +0100, Hanjun Guo wrote: +#ifdef CONFIG_ACPI +/* Configure some sensible defaults for ACPI mode */ +static int

Re: [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Mon, Sep 01, 2014 at 06:32:45PM +0100, Graeme Gregory wrote: This will of course most likely be replaced by _DSD values. I just hardcoded for now as _DSD is not yet in the kernel and issues around maintenance of bindings are not solved (unless this happened at KS where I was not present).