On 04/10/2014 12:05 PM, Borislav Petkov wrote:
> On Thu, Apr 10, 2014 at 12:00:47PM +0200, Borislav Petkov wrote:
>> Then you'll have to check whether edac can even stomach more than one
>> drivers in parallel. TTBOMK, no one has ever done this so far... Yadda
>> yadda.
>
> Alternatively, you
On 04/10/2014 12:00 PM, Borislav Petkov wrote:
> On Thu, Apr 10, 2014 at 11:49:57AM +0200, Michal Simek wrote:
>> I agree with you that we can use shorter name. I have checked this
>> with Punnaiah and I can't see any problem to have more edac drivers
>> in the system. For zynq there is primary
On Thu, Apr 10, 2014 at 12:00:47PM +0200, Borislav Petkov wrote:
> Then you'll have to check whether edac can even stomach more than one
> drivers in parallel. TTBOMK, no one has ever done this so far... Yadda
> yadda.
Alternatively, you could put together a single edac driver which
contains both
On Thu, Apr 10, 2014 at 11:49:57AM +0200, Michal Simek wrote:
> I agree with you that we can use shorter name. I have checked this
> with Punnaiah and I can't see any problem to have more edac drivers
> in the system. For zynq there is primary ddr controller which is
> target by this driver. Then
On 04/10/2014 11:21 AM, Borislav Petkov wrote:
> On Thu, Apr 10, 2014 at 08:01:36AM +0200, Michal Simek wrote:
>> Just add it to Zynq maintainer fragment as we are doing for non
>> zynq/xilinx drivers.
>
> Yep, as a file pattern F:
yep.
>> At least the is the first time when someone saying that
On Thu, Apr 10, 2014 at 08:01:36AM +0200, Michal Simek wrote:
> Just add it to Zynq maintainer fragment as we are doing for non
> zynq/xilinx drivers.
Yep, as a file pattern F:
> At least the is the first time when someone saying that only some
> functions should be documented.
I don't see the
Hi Borislav and Punnaiah,
some comments below.
>> diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
>> new file mode 100644
>> index 000..7cec331
>> --- /dev/null
>> +++ b/drivers/edac/synopsys_edac.c
>> @@ -0,0 +1,614 @@
>> +/*
>> + * Synopsys DDR ECC Driver
>> + *
Hi Borislav and Punnaiah,
some comments below.
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
new file mode 100644
index 000..7cec331
--- /dev/null
+++ b/drivers/edac/synopsys_edac.c
@@ -0,0 +1,614 @@
+/*
+ * Synopsys DDR ECC Driver
+ * This driver is based
On Thu, Apr 10, 2014 at 08:01:36AM +0200, Michal Simek wrote:
Just add it to Zynq maintainer fragment as we are doing for non
zynq/xilinx drivers.
Yep, as a file pattern F:
At least the is the first time when someone saying that only some
functions should be documented.
I don't see the need
On 04/10/2014 11:21 AM, Borislav Petkov wrote:
On Thu, Apr 10, 2014 at 08:01:36AM +0200, Michal Simek wrote:
Just add it to Zynq maintainer fragment as we are doing for non
zynq/xilinx drivers.
Yep, as a file pattern F:
yep.
At least the is the first time when someone saying that only
On Thu, Apr 10, 2014 at 11:49:57AM +0200, Michal Simek wrote:
I agree with you that we can use shorter name. I have checked this
with Punnaiah and I can't see any problem to have more edac drivers
in the system. For zynq there is primary ddr controller which is
target by this driver. Then we
On Thu, Apr 10, 2014 at 12:00:47PM +0200, Borislav Petkov wrote:
Then you'll have to check whether edac can even stomach more than one
drivers in parallel. TTBOMK, no one has ever done this so far... Yadda
yadda.
Alternatively, you could put together a single edac driver which
contains both
On 04/10/2014 12:00 PM, Borislav Petkov wrote:
On Thu, Apr 10, 2014 at 11:49:57AM +0200, Michal Simek wrote:
I agree with you that we can use shorter name. I have checked this
with Punnaiah and I can't see any problem to have more edac drivers
in the system. For zynq there is primary ddr
On 04/10/2014 12:05 PM, Borislav Petkov wrote:
On Thu, Apr 10, 2014 at 12:00:47PM +0200, Borislav Petkov wrote:
Then you'll have to check whether edac can even stomach more than one
drivers in parallel. TTBOMK, no one has ever done this so far... Yadda
yadda.
Alternatively, you could put
On Wed, Apr 09, 2014 at 11:15:00PM +0530, punnaiah choudary kalluri wrote:
> OK. I just checked at highbank_mc_edac and other drivers found
> no documentation for static functions. So, is it ok if i remove
> documentation completely for these static functions?
Yes. Didn't I already suggested
On Wed, Apr 9, 2014 at 4:33 PM, Borislav Petkov wrote:
> On Wed, Apr 09, 2014 at 11:34:31AM +0530, punnaiah choudary kalluri wrote:
>> Since it is recommended in Documentation/kernel-doc-nano-HOWTO.txt
>> but also said it is low priority and at the discretion of the MAINTAINER of
>> that kernel
On Wed, Apr 09, 2014 at 11:34:31AM +0530, punnaiah choudary kalluri wrote:
> Since it is recommended in Documentation/kernel-doc-nano-HOWTO.txt
> but also said it is low priority and at the discretion of the MAINTAINER of
> that kernel source file
>
> So, if you recommend not use kernel-doc
On Wed, Apr 9, 2014 at 2:10 AM, Borislav Petkov wrote:
> On Mon, Mar 17, 2014 at 10:53:44AM +0530, Punnaiah Choudary Kalluri wrote:
>> Added EDAC support for reporting the ecc errors of synopsys ddr controller.
>> The ddr ecc controller corrects single bit errors and detects double bit
>> errors
On Wed, Apr 9, 2014 at 2:10 AM, Borislav Petkov b...@alien8.de wrote:
On Mon, Mar 17, 2014 at 10:53:44AM +0530, Punnaiah Choudary Kalluri wrote:
Added EDAC support for reporting the ecc errors of synopsys ddr controller.
The ddr ecc controller corrects single bit errors and detects double bit
On Wed, Apr 09, 2014 at 11:34:31AM +0530, punnaiah choudary kalluri wrote:
Since it is recommended in Documentation/kernel-doc-nano-HOWTO.txt
but also said it is low priority and at the discretion of the MAINTAINER of
that kernel source file
So, if you recommend not use kernel-doc annotation
On Wed, Apr 9, 2014 at 4:33 PM, Borislav Petkov b...@alien8.de wrote:
On Wed, Apr 09, 2014 at 11:34:31AM +0530, punnaiah choudary kalluri wrote:
Since it is recommended in Documentation/kernel-doc-nano-HOWTO.txt
but also said it is low priority and at the discretion of the MAINTAINER of
that
On Wed, Apr 09, 2014 at 11:15:00PM +0530, punnaiah choudary kalluri wrote:
OK. I just checked at highbank_mc_edac and other drivers found
no documentation for static functions. So, is it ok if i remove
documentation completely for these static functions?
Yes. Didn't I already suggested that,
On Mon, Mar 17, 2014 at 10:53:44AM +0530, Punnaiah Choudary Kalluri wrote:
> Added EDAC support for reporting the ecc errors of synopsys ddr controller.
> The ddr ecc controller corrects single bit errors and detects double bit
> errors
>
> Signed-off-by: Punnaiah Choudary Kalluri
> ---
>
On Mon, Mar 17, 2014 at 10:53:44AM +0530, Punnaiah Choudary Kalluri wrote:
Added EDAC support for reporting the ecc errors of synopsys ddr controller.
The ddr ecc controller corrects single bit errors and detects double bit
errors
Signed-off-by: Punnaiah Choudary Kalluri punn...@xilinx.com
Hi Borislav,
On 03/17/2014 06:23 AM, Punnaiah Choudary Kalluri wrote:
> Added EDAC support for reporting the ecc errors of synopsys ddr controller.
> The ddr ecc controller corrects single bit errors and detects double bit
> errors
>
> Signed-off-by: Punnaiah Choudary Kalluri
> ---
> Changes
Hi Borislav,
On 03/17/2014 06:23 AM, Punnaiah Choudary Kalluri wrote:
Added EDAC support for reporting the ecc errors of synopsys ddr controller.
The ddr ecc controller corrects single bit errors and detects double bit
errors
Signed-off-by: Punnaiah Choudary Kalluri punn...@xilinx.com
---
Added EDAC support for reporting the ecc errors of synopsys ddr controller.
The ddr ecc controller corrects single bit errors and detects double bit
errors
Signed-off-by: Punnaiah Choudary Kalluri
---
Changes for v2:
- Updated the commit header and message
- Renamed the filenames to
Added EDAC support for reporting the ecc errors of synopsys ddr controller.
The ddr ecc controller corrects single bit errors and detects double bit
errors
Signed-off-by: Punnaiah Choudary Kalluri punn...@xilinx.com
---
Changes for v2:
- Updated the commit header and message
- Renamed the
28 matches
Mail list logo
