Re: [RFC PATCH v2] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-18 Thread Matti Vaittinen
On Mon, Dec 17, 2018 at 06:07:22PM +, Mark Brown wrote: > On Mon, Dec 17, 2018 at 10:42:48AM +0200, Matti Vaittinen wrote: > > On Thu, Dec 13, 2018 at 06:20:26PM +, Mark Brown wrote: > > > > I can't remember and can't find any record of any discussion of it which > > > is odd, might've

Re: [RFC PATCH v2] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-17 Thread Mark Brown
On Mon, Dec 17, 2018 at 10:42:48AM +0200, Matti Vaittinen wrote: > On Thu, Dec 13, 2018 at 06:20:26PM +, Mark Brown wrote: > > I can't remember and can't find any record of any discussion of it which > > is odd, might've been on IRC or something. Let's just remove it and see > > what breaks,

Re: [RFC PATCH v2] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-17 Thread Matti Vaittinen
Hello Mark, On Thu, Dec 13, 2018 at 06:20:26PM +, Mark Brown wrote: > On Tue, Dec 11, 2018 at 04:05:55PM +0200, Matti Vaittinen wrote: > > > One specific question hit me while doing this. Why does the regmap-irq > > core do default trigger type configuration? I did leave this in the > >

Re: [RFC PATCH v2] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-13 Thread Mark Brown
On Tue, Dec 11, 2018 at 04:05:55PM +0200, Matti Vaittinen wrote: > One specific question hit me while doing this. Why does the regmap-irq > core do default trigger type configuration? I did leave this in the > patch - but to me it is strange. For me it would be unexpected that the > HW default

[RFC PATCH v2] regmap: regmap-irq/gpio-max77620: add level-irq support

2018-12-11 Thread Matti Vaittinen
Add level active IRQ support to regmap-irq irqchip. Change breaks existing regmap-irq type setting. Convert the existing drivers which use regmap-irq with trigger type setting (gpio-max77620) to work with this new approach. So we do not magically support level-active IRQs on gpio-max77620 - but