Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-05 Thread Rafael J. Wysocki
On Tuesday, February 05, 2013 10:39:48 AM Greg KH wrote: > On Tue, Feb 05, 2013 at 12:11:17PM +0100, Rafael J. Wysocki wrote: > > On Monday, February 04, 2013 04:04:47 PM Greg KH wrote: > > > On Tue, Feb 05, 2013 at 12:52:30AM +0100, Rafael J. Wysocki wrote: > > > > You'd probably never try to hot-

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-05 Thread Greg KH
On Tue, Feb 05, 2013 at 12:11:17PM +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 04:04:47 PM Greg KH wrote: > > On Tue, Feb 05, 2013 at 12:52:30AM +0100, Rafael J. Wysocki wrote: > > > You'd probably never try to hot-remove a disk before unmounting > > > filesystems > > > mounted

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-05 Thread Rafael J. Wysocki
On Monday, February 04, 2013 04:04:47 PM Greg KH wrote: > On Tue, Feb 05, 2013 at 12:52:30AM +0100, Rafael J. Wysocki wrote: > > You'd probably never try to hot-remove a disk before unmounting filesystems > > mounted from it or failing it as a RAID component and nobody sane wants the > > kernel to

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Tue, 2013-02-05 at 00:52 +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 03:13:29 PM Toshi Kani wrote: > > On Mon, 2013-02-04 at 21:07 +0100, Rafael J. Wysocki wrote: > > > On Monday, February 04, 2013 06:33:52 AM Greg KH wrote: > > > > On Mon, Feb 04, 2013 at 03:21:22PM +0100, Ra

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 04:04:47 PM Greg KH wrote: > On Tue, Feb 05, 2013 at 12:52:30AM +0100, Rafael J. Wysocki wrote: > > You'd probably never try to hot-remove a disk before unmounting filesystems > > mounted from it or failing it as a RAID component and nobody sane wants the > > kernel to

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Greg KH
On Tue, Feb 05, 2013 at 12:52:30AM +0100, Rafael J. Wysocki wrote: > You'd probably never try to hot-remove a disk before unmounting filesystems > mounted from it or failing it as a RAID component and nobody sane wants the > kernel to do things like that automatically when the user presses the ejec

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 03:13:29 PM Toshi Kani wrote: > On Mon, 2013-02-04 at 21:07 +0100, Rafael J. Wysocki wrote: > > On Monday, February 04, 2013 06:33:52 AM Greg KH wrote: > > > On Mon, Feb 04, 2013 at 03:21:22PM +0100, Rafael J. Wysocki wrote: > > > > On Monday, February 04, 2013 04:48:10

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Tue, 2013-02-05 at 00:23 +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 01:59:27 PM Toshi Kani wrote: > > On Mon, 2013-02-04 at 20:45 +0100, Rafael J. Wysocki wrote: > > > On Monday, February 04, 2013 09:46:18 AM Toshi Kani wrote: > > > > On Mon, 2013-02-04 at 04:46 -0800, Greg K

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 01:59:27 PM Toshi Kani wrote: > On Mon, 2013-02-04 at 20:45 +0100, Rafael J. Wysocki wrote: > > On Monday, February 04, 2013 09:46:18 AM Toshi Kani wrote: > > > On Mon, 2013-02-04 at 04:46 -0800, Greg KH wrote: > > > > On Sun, Feb 03, 2013 at 05:28:09PM -0700, Toshi Kan

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 01:34:18 PM Toshi Kani wrote: > On Mon, 2013-02-04 at 21:12 +0100, Rafael J. Wysocki wrote: > > On Monday, February 04, 2013 12:46:24 PM Toshi Kani wrote: > > > On Mon, 2013-02-04 at 20:48 +0100, Rafael J. Wysocki wrote: > > > > On Monday, February 04, 2013 09:02:46 AM

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Mon, 2013-02-04 at 21:07 +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 06:33:52 AM Greg KH wrote: > > On Mon, Feb 04, 2013 at 03:21:22PM +0100, Rafael J. Wysocki wrote: > > > On Monday, February 04, 2013 04:48:10 AM Greg KH wrote: > > > > On Sun, Feb 03, 2013 at 09:44:39PM +0100

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Mon, 2013-02-04 at 20:45 +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 09:46:18 AM Toshi Kani wrote: > > On Mon, 2013-02-04 at 04:46 -0800, Greg KH wrote: > > > On Sun, Feb 03, 2013 at 05:28:09PM -0700, Toshi Kani wrote: > > > > On Sat, 2013-02-02 at 16:01 +0100, Greg KH wrote:

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Mon, 2013-02-04 at 21:12 +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 12:46:24 PM Toshi Kani wrote: > > On Mon, 2013-02-04 at 20:48 +0100, Rafael J. Wysocki wrote: > > > On Monday, February 04, 2013 09:02:46 AM Toshi Kani wrote: > > > > On Mon, 2013-02-04 at 14:41 +0100, Rafael

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 12:46:24 PM Toshi Kani wrote: > On Mon, 2013-02-04 at 20:48 +0100, Rafael J. Wysocki wrote: > > On Monday, February 04, 2013 09:02:46 AM Toshi Kani wrote: > > > On Mon, 2013-02-04 at 14:41 +0100, Rafael J. Wysocki wrote: > > > > On Sunday, February 03, 2013 07:23:49 PM

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 06:33:52 AM Greg KH wrote: > On Mon, Feb 04, 2013 at 03:21:22PM +0100, Rafael J. Wysocki wrote: > > On Monday, February 04, 2013 04:48:10 AM Greg KH wrote: > > > On Sun, Feb 03, 2013 at 09:44:39PM +0100, Rafael J. Wysocki wrote: > > > > > Yes, but those are just remove

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Mon, 2013-02-04 at 20:48 +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 09:02:46 AM Toshi Kani wrote: > > On Mon, 2013-02-04 at 14:41 +0100, Rafael J. Wysocki wrote: > > > On Sunday, February 03, 2013 07:23:49 PM Greg KH wrote: > > > > On Sat, Feb 02, 2013 at 09:15:37PM +0100, Ra

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 09:02:46 AM Toshi Kani wrote: > On Mon, 2013-02-04 at 14:41 +0100, Rafael J. Wysocki wrote: > > On Sunday, February 03, 2013 07:23:49 PM Greg KH wrote: > > > On Sat, Feb 02, 2013 at 09:15:37PM +0100, Rafael J. Wysocki wrote: > > > > On Saturday, February 02, 2013 03:58:

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 09:46:18 AM Toshi Kani wrote: > On Mon, 2013-02-04 at 04:46 -0800, Greg KH wrote: > > On Sun, Feb 03, 2013 at 05:28:09PM -0700, Toshi Kani wrote: > > > On Sat, 2013-02-02 at 16:01 +0100, Greg KH wrote: > > > > On Fri, Feb 01, 2013 at 01:40:10PM -0700, Toshi Kani wrote:

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 09:19:09 AM Toshi Kani wrote: > On Mon, 2013-02-04 at 15:21 +0100, Rafael J. Wysocki wrote: > > On Monday, February 04, 2013 04:48:10 AM Greg KH wrote: > > > On Sun, Feb 03, 2013 at 09:44:39PM +0100, Rafael J. Wysocki wrote: > > > > > Yes, but those are just remove even

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Mon, 2013-02-04 at 04:46 -0800, Greg KH wrote: > On Sun, Feb 03, 2013 at 05:28:09PM -0700, Toshi Kani wrote: > > On Sat, 2013-02-02 at 16:01 +0100, Greg KH wrote: > > > On Fri, Feb 01, 2013 at 01:40:10PM -0700, Toshi Kani wrote: > > > > On Fri, 2013-02-01 at 07:30 +, Greg KH wrote: > > > > >

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Mon, 2013-02-04 at 15:21 +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 04:48:10 AM Greg KH wrote: > > On Sun, Feb 03, 2013 at 09:44:39PM +0100, Rafael J. Wysocki wrote: > > > > Yes, but those are just remove events and we can only see how > > > > destructive they > > > > were a

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Toshi Kani
On Mon, 2013-02-04 at 14:41 +0100, Rafael J. Wysocki wrote: > On Sunday, February 03, 2013 07:23:49 PM Greg KH wrote: > > On Sat, Feb 02, 2013 at 09:15:37PM +0100, Rafael J. Wysocki wrote: > > > On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: : > > > Yes, but those are just remove event

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Greg KH
On Mon, Feb 04, 2013 at 03:21:22PM +0100, Rafael J. Wysocki wrote: > On Monday, February 04, 2013 04:48:10 AM Greg KH wrote: > > On Sun, Feb 03, 2013 at 09:44:39PM +0100, Rafael J. Wysocki wrote: > > > > Yes, but those are just remove events and we can only see how > > > > destructive they > > > >

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Monday, February 04, 2013 04:48:10 AM Greg KH wrote: > On Sun, Feb 03, 2013 at 09:44:39PM +0100, Rafael J. Wysocki wrote: > > > Yes, but those are just remove events and we can only see how destructive > > > they > > > were after the removal. The point is to be able to figure out whether or >

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Rafael J. Wysocki
On Sunday, February 03, 2013 07:23:49 PM Greg KH wrote: > On Sat, Feb 02, 2013 at 09:15:37PM +0100, Rafael J. Wysocki wrote: > > On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: > > > On Fri, Feb 01, 2013 at 11:12:59PM +0100, Rafael J. Wysocki wrote: > > > > On Friday, February 01, 2013 08

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Greg KH
On Sun, Feb 03, 2013 at 09:44:39PM +0100, Rafael J. Wysocki wrote: > > Yes, but those are just remove events and we can only see how destructive > > they > > were after the removal. The point is to be able to figure out whether or > > not > > we *want* to do the removal in the first place. > >

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-04 Thread Greg KH
On Sun, Feb 03, 2013 at 05:28:09PM -0700, Toshi Kani wrote: > On Sat, 2013-02-02 at 16:01 +0100, Greg KH wrote: > > On Fri, Feb 01, 2013 at 01:40:10PM -0700, Toshi Kani wrote: > > > On Fri, 2013-02-01 at 07:30 +, Greg KH wrote: > > > > On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote:

Re: [PATCH?] Move ACPI device nodes under /sys/firmware/acpi (was: Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework)

2013-02-04 Thread Rafael J. Wysocki
On Sunday, February 03, 2013 07:24:47 PM Greg KH wrote: > On Sat, Feb 02, 2013 at 11:18:20PM +0100, Rafael J. Wysocki wrote: > > On Saturday, February 02, 2013 09:15:37 PM Rafael J. Wysocki wrote: > > > On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: > > [...] > > > > > > > I know it's m

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-03 Thread Greg KH
On Sat, Feb 02, 2013 at 09:15:37PM +0100, Rafael J. Wysocki wrote: > On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: > > On Fri, Feb 01, 2013 at 11:12:59PM +0100, Rafael J. Wysocki wrote: > > > On Friday, February 01, 2013 08:23:12 AM Greg KH wrote: > > > > On Thu, Jan 31, 2013 at 09:54:5

Re: [PATCH?] Move ACPI device nodes under /sys/firmware/acpi (was: Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework)

2013-02-03 Thread Greg KH
On Sat, Feb 02, 2013 at 11:18:20PM +0100, Rafael J. Wysocki wrote: > On Saturday, February 02, 2013 09:15:37 PM Rafael J. Wysocki wrote: > > On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: > [...] > > > > > I know it's more complicated with these types of devices, and I think we > > > ar

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-03 Thread Toshi Kani
On Sat, 2013-02-02 at 16:01 +0100, Greg KH wrote: > On Fri, Feb 01, 2013 at 01:40:10PM -0700, Toshi Kani wrote: > > On Fri, 2013-02-01 at 07:30 +, Greg KH wrote: > > > On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote: > > > > This is already done for PCI host bridges and platform dev

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-03 Thread Rafael J. Wysocki
On Saturday, February 02, 2013 09:15:37 PM Rafael J. Wysocki wrote: > On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: > > On Fri, Feb 01, 2013 at 11:12:59PM +0100, Rafael J. Wysocki wrote: > > > On Friday, February 01, 2013 08:23:12 AM Greg KH wrote: > > > > On Thu, Jan 31, 2013 at 09:54:

[PATCH?] Move ACPI device nodes under /sys/firmware/acpi (was: Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework)

2013-02-02 Thread Rafael J. Wysocki
On Saturday, February 02, 2013 09:15:37 PM Rafael J. Wysocki wrote: > On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: [...] > > > I know it's more complicated with these types of devices, and I think we > > are getting closer to the correct solution, I just don't want to ever > > see dup

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-02 Thread Rafael J. Wysocki
On Saturday, February 02, 2013 03:58:01 PM Greg KH wrote: > On Fri, Feb 01, 2013 at 11:12:59PM +0100, Rafael J. Wysocki wrote: > > On Friday, February 01, 2013 08:23:12 AM Greg KH wrote: > > > On Thu, Jan 31, 2013 at 09:54:51PM +0100, Rafael J. Wysocki wrote: > > > > > > But, again, I'm going to as

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-02 Thread Greg KH
On Fri, Feb 01, 2013 at 01:40:10PM -0700, Toshi Kani wrote: > On Fri, 2013-02-01 at 07:30 +, Greg KH wrote: > > On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote: > > > This is already done for PCI host bridges and platform devices and I > > don't > > > > see why we can't do that for

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-02 Thread Greg KH
On Fri, Feb 01, 2013 at 11:12:59PM +0100, Rafael J. Wysocki wrote: > On Friday, February 01, 2013 08:23:12 AM Greg KH wrote: > > On Thu, Jan 31, 2013 at 09:54:51PM +0100, Rafael J. Wysocki wrote: > > > > > But, again, I'm going to ask why you aren't using the existing cpu / > > > > > memory / bridg

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-01 Thread Toshi Kani
On Fri, 2013-02-01 at 23:21 +0100, Rafael J. Wysocki wrote: > On Friday, February 01, 2013 01:40:10 PM Toshi Kani wrote: > > On Fri, 2013-02-01 at 07:30 +, Greg KH wrote: > > > On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote: > > > > This is already done for PCI host bridges and pla

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-01 Thread Rafael J. Wysocki
On Friday, February 01, 2013 01:40:10 PM Toshi Kani wrote: > On Fri, 2013-02-01 at 07:30 +, Greg KH wrote: > > On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote: > > > This is already done for PCI host bridges and platform devices and I > > don't > > > > see why we can't do that for

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-01 Thread Rafael J. Wysocki
On Friday, February 01, 2013 08:23:12 AM Greg KH wrote: > On Thu, Jan 31, 2013 at 09:54:51PM +0100, Rafael J. Wysocki wrote: > > > > But, again, I'm going to ask why you aren't using the existing cpu / > > > > memory / bridge / node devices that we have in the kernel. Please use > > > > them, or g

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-02-01 Thread Toshi Kani
On Fri, 2013-02-01 at 07:30 +, Greg KH wrote: > On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote: > > This is already done for PCI host bridges and platform devices and I don't > > > see why we can't do that for the other types of devices too. > > > > > > The only missing piece I se

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Greg KH
On Thu, Jan 31, 2013 at 06:32:18PM -0700, Toshi Kani wrote: > This is already done for PCI host bridges and platform devices and I don't > > see why we can't do that for the other types of devices too. > > > > The only missing piece I see is a way to handle the "eject" problem, i.e. > > when we t

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Greg KH
On Thu, Jan 31, 2013 at 09:54:51PM +0100, Rafael J. Wysocki wrote: > > > But, again, I'm going to ask why you aren't using the existing cpu / > > > memory / bridge / node devices that we have in the kernel. Please use > > > them, or give me a _really_ good reason why they will not work. > > > > W

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Toshi Kani
On Thu, 2013-01-31 at 21:54 +0100, Rafael J. Wysocki wrote: > On Wednesday, January 30, 2013 07:57:45 PM Toshi Kani wrote: > > On Tue, 2013-01-29 at 23:58 -0500, Greg KH wrote: > > > On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: : > > > > +}; > > > > + > > > > +struct shp_device { >

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Rafael J. Wysocki
On Wednesday, January 30, 2013 07:57:45 PM Toshi Kani wrote: > On Tue, 2013-01-29 at 23:58 -0500, Greg KH wrote: > > On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: > > > +/* > > > + * Hot-plug device information > > > + */ > > > > Again, stop it with the "generic" hotplug term here, a

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-31 Thread Toshi Kani
On Thu, 2013-01-31 at 05:24 +, Greg KH wrote: > On Wed, Jan 30, 2013 at 06:15:12PM -0700, Toshi Kani wrote: > > > Please make it a "real" pointer, and not a void *, those shouldn't be > > > used at all if possible. > > > > How about changing the "void *handle" to acpi_dev_node below? > > >

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-30 Thread Greg KH
On Wed, Jan 30, 2013 at 06:15:12PM -0700, Toshi Kani wrote: > > Please make it a "real" pointer, and not a void *, those shouldn't be > > used at all if possible. > > How about changing the "void *handle" to acpi_dev_node below? > >struct acpi_dev_nodeacpi_node; > > Basically, it has

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-30 Thread Toshi Kani
On Tue, 2013-01-29 at 23:58 -0500, Greg KH wrote: > On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: > > +/* > > + * Hot-plug device information > > + */ > > Again, stop it with the "generic" hotplug term here, and everywhere > else. You are doing a very _specific_ type of hotplug devi

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-30 Thread Toshi Kani
On Tue, 2013-01-29 at 23:53 -0500, Greg KH wrote: > On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: > > Added include/linux/sys_hotplug.h, which defines the system device > > hotplug framework interfaces used by the framework itself and > > handlers. > > > > The order values define the

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-30 Thread Toshi Kani
On Tue, 2013-01-29 at 23:48 -0500, Greg KH wrote: > On Mon, Jan 14, 2013 at 12:02:04PM -0700, Toshi Kani wrote: > > On Mon, 2013-01-14 at 19:48 +0100, Rafael J. Wysocki wrote: > > > On Monday, January 14, 2013 08:33:48 AM Toshi Kani wrote: > > > > On Fri, 2013-01-11 at 22:23 +0100, Rafael J. Wysock

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-30 Thread Greg KH
On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: > +/* > + * Hot-plug device information > + */ Again, stop it with the "generic" hotplug term here, and everywhere else. You are doing a very _specific_ type of hotplug devices, so spell it out. We've worked hard to hotplug _everything_

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-30 Thread Greg KH
On Thu, Jan 10, 2013 at 04:40:19PM -0700, Toshi Kani wrote: > Added include/linux/sys_hotplug.h, which defines the system device > hotplug framework interfaces used by the framework itself and > handlers. > > The order values define the calling sequence of handlers. For add > execute, the orderin

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-30 Thread Greg KH
On Mon, Jan 14, 2013 at 12:02:04PM -0700, Toshi Kani wrote: > On Mon, 2013-01-14 at 19:48 +0100, Rafael J. Wysocki wrote: > > On Monday, January 14, 2013 08:33:48 AM Toshi Kani wrote: > > > On Fri, 2013-01-11 at 22:23 +0100, Rafael J. Wysocki wrote: > > > > On Thursday, January 10, 2013 04:40:19 PM

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-14 Thread Toshi Kani
On Mon, 2013-01-14 at 19:48 +0100, Rafael J. Wysocki wrote: > On Monday, January 14, 2013 08:33:48 AM Toshi Kani wrote: > > On Fri, 2013-01-11 at 22:23 +0100, Rafael J. Wysocki wrote: > > > On Thursday, January 10, 2013 04:40:19 PM Toshi Kani wrote: > > > > Added include/linux/sys_hotplug.h, which

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-14 Thread Rafael J. Wysocki
On Monday, January 14, 2013 08:33:48 AM Toshi Kani wrote: > On Fri, 2013-01-11 at 22:23 +0100, Rafael J. Wysocki wrote: > > On Thursday, January 10, 2013 04:40:19 PM Toshi Kani wrote: > > > Added include/linux/sys_hotplug.h, which defines the system device > > > hotplug framework interfaces used by

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-14 Thread Toshi Kani
On Fri, 2013-01-11 at 22:23 +0100, Rafael J. Wysocki wrote: > On Thursday, January 10, 2013 04:40:19 PM Toshi Kani wrote: > > Added include/linux/sys_hotplug.h, which defines the system device > > hotplug framework interfaces used by the framework itself and > > handlers. > > > > The order values

Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-11 Thread Rafael J. Wysocki
On Thursday, January 10, 2013 04:40:19 PM Toshi Kani wrote: > Added include/linux/sys_hotplug.h, which defines the system device > hotplug framework interfaces used by the framework itself and > handlers. > > The order values define the calling sequence of handlers. For add > execute, the orderin

[RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework

2013-01-10 Thread Toshi Kani
Added include/linux/sys_hotplug.h, which defines the system device hotplug framework interfaces used by the framework itself and handlers. The order values define the calling sequence of handlers. For add execute, the ordering is ACPI->MEM->CPU. Memory is onlined before CPU so that threads on ne