Re: [RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Kim Phillips
On Fri, 13 Jan 2017 17:03:07 + Will Deacon wrote: > On Fri, Jan 13, 2017 at 10:40:42AM -0600, Kim Phillips wrote: > > On Fri, 13 Jan 2017 16:03:48 + > > Will Deacon wrote: > > > > > +#define DRVNAME "arm_spe_pmu" > > >

Re: [RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Kim Phillips
On Fri, 13 Jan 2017 17:03:07 + Will Deacon wrote: > On Fri, Jan 13, 2017 at 10:40:42AM -0600, Kim Phillips wrote: > > On Fri, 13 Jan 2017 16:03:48 + > > Will Deacon wrote: > > > > > +#define DRVNAME "arm_spe_pmu" > > > > PMU is implied. "arm_spe"? > > As

Re: [RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Will Deacon
On Fri, Jan 13, 2017 at 10:40:42AM -0600, Kim Phillips wrote: > On Fri, 13 Jan 2017 16:03:48 + > Will Deacon wrote: > > > +#define DRVNAME"arm_spe_pmu" > > PMU is implied. "arm_spe"? As stated before, I'm going for consistency here. Is it

Re: [RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Will Deacon
On Fri, Jan 13, 2017 at 10:40:42AM -0600, Kim Phillips wrote: > On Fri, 13 Jan 2017 16:03:48 + > Will Deacon wrote: > > > +#define DRVNAME"arm_spe_pmu" > > PMU is implied. "arm_spe"? As stated before, I'm going for consistency here. Is it causing any real

Re: [RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Kim Phillips
On Fri, 13 Jan 2017 16:03:48 + Will Deacon wrote: > +#define DRVNAME "arm_spe_pmu" PMU is implied. "arm_spe"? > +static int arm_spe_pmu_event_init(struct perf_event *event) > +{ > + u64 reg; > + struct perf_event_attr *attr =

Re: [RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Kim Phillips
On Fri, 13 Jan 2017 16:03:48 + Will Deacon wrote: > +#define DRVNAME "arm_spe_pmu" PMU is implied. "arm_spe"? > +static int arm_spe_pmu_event_init(struct perf_event *event) > +{ > + u64 reg; > + struct perf_event_attr *attr = >attr; > + struct

[RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Will Deacon
The ARMv8.2 architecture introduces the optional Statistical Profiling Extension (SPE). SPE can be used to profile a population of operations in the CPU pipeline after instruction decode. These are either architected instructions (i.e. a dynamic instruction trace) or CPU-specific uops and the

[RFC PATCH v2 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension

2017-01-13 Thread Will Deacon
The ARMv8.2 architecture introduces the optional Statistical Profiling Extension (SPE). SPE can be used to profile a population of operations in the CPU pipeline after instruction decode. These are either architected instructions (i.e. a dynamic instruction trace) or CPU-specific uops and the