Re: [RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-28 Thread Luis Henriques
On Thu, Aug 28, 2014 at 05:40:22PM +0900, Masami Hiramatsu wrote: > (2014/08/28 0:54), Luis Henriques wrote: > > Hi, > > > > Not really a complete review, but just 2 comments on this script: > > > > On Tue, Aug 26, 2014 at 11:15:18AM +, Masami Hiramatsu wrote: > > ... > >> +prlog() { #

Re: [RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-28 Thread Masami Hiramatsu
(2014/08/28 0:54), Luis Henriques wrote: > Hi, > > Not really a complete review, but just 2 comments on this script: > > On Tue, Aug 26, 2014 at 11:15:18AM +, Masami Hiramatsu wrote: > ... >> +prlog() { # messages >> + echo $@ | tee -a $LOG_FILE >> +} >> +catlog() { #file >> + cat $1 | tee

Re: [RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-28 Thread Masami Hiramatsu
(2014/08/28 0:54), Luis Henriques wrote: Hi, Not really a complete review, but just 2 comments on this script: On Tue, Aug 26, 2014 at 11:15:18AM +, Masami Hiramatsu wrote: ... +prlog() { # messages + echo $@ | tee -a $LOG_FILE +} +catlog() { #file + cat $1 | tee -a $LOG_FILE

Re: [RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-28 Thread Luis Henriques
On Thu, Aug 28, 2014 at 05:40:22PM +0900, Masami Hiramatsu wrote: (2014/08/28 0:54), Luis Henriques wrote: Hi, Not really a complete review, but just 2 comments on this script: On Tue, Aug 26, 2014 at 11:15:18AM +, Masami Hiramatsu wrote: ... +prlog() { # messages + echo $@

Re: [RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-27 Thread Luis Henriques
Hi, Not really a complete review, but just 2 comments on this script: On Tue, Aug 26, 2014 at 11:15:18AM +, Masami Hiramatsu wrote: ... > +prlog() { # messages > + echo $@ | tee -a $LOG_FILE > +} > +catlog() { #file > + cat $1 | tee -a $LOG_FILE > +} > + > +# Testcase management >

Re: [RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-27 Thread Luis Henriques
Hi, Not really a complete review, but just 2 comments on this script: On Tue, Aug 26, 2014 at 11:15:18AM +, Masami Hiramatsu wrote: ... +prlog() { # messages + echo $@ | tee -a $LOG_FILE +} +catlog() { #file + cat $1 | tee -a $LOG_FILE +} + +# Testcase management +PASSED_CASES=

[RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-26 Thread Masami Hiramatsu
ftracetest is a collection of testcase shell-scripts for ftrace. To avoid regressions of ftrace, these testcases check correct ftrace behaviors. If someone would like to add any features on ftrace, the patch series should have at least one testcase for checking the new behavior. Changes in v2: -

[RFC PATCH v2 1/4] ftracetest: Initial commit for ftracetest

2014-08-26 Thread Masami Hiramatsu
ftracetest is a collection of testcase shell-scripts for ftrace. To avoid regressions of ftrace, these testcases check correct ftrace behaviors. If someone would like to add any features on ftrace, the patch series should have at least one testcase for checking the new behavior. Changes in v2: -