Re: [RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:49 +0800 Xunlei Pang wrote: > + else if (rtc->ops->set_mmss64) { > + ; > + > + secs64 = rtc_tm_to_time64(tm); time64_t secs64 = rtc_tm_to_time64(tm); would do as well. add spaces, variables and empty lines only when required for

[RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement

2015-01-13 Thread Xunlei Pang
From: Xunlei Pang Currently the rtc_class_op's set_mmss() function takes a 32bit second value (on 32bit systems), which is problematic for dates past y2038. This patch provides a safe version named set_mmss64() using y2038 safe time64_t. After this patch, set_mmss() is deprecated and all its

Re: [RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:49 +0800 Xunlei Pang xlp...@126.com wrote: + else if (rtc-ops-set_mmss64) { + ; + + secs64 = rtc_tm_to_time64(tm); time64_t secs64 = rtc_tm_to_time64(tm); would do as well. add spaces, variables and empty lines only when required for

[RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement

2015-01-13 Thread Xunlei Pang
From: Xunlei Pang pang.xun...@linaro.org Currently the rtc_class_op's set_mmss() function takes a 32bit second value (on 32bit systems), which is problematic for dates past y2038. This patch provides a safe version named set_mmss64() using y2038 safe time64_t. After this patch, set_mmss() is