Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/28/2018 9:32 PM, Steven Rostedt wrote: On Tue, 28 Aug 2018 18:47:33 +0530 Sai Prakash Ranjan wrote: On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/28/2018 9:32 PM, Steven Rostedt wrote: On Tue, 28 Aug 2018 18:47:33 +0530 Sai Prakash Ranjan wrote: On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Steven Rostedt
On Tue, 28 Aug 2018 18:47:33 +0530 Sai Prakash Ranjan wrote: > On 8/27/2018 9:45 PM, Steven Rostedt wrote: > > On Sat, 25 Aug 2018 12:54:07 +0530 > > Sai Prakash Ranjan wrote: > > > > > >> Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not > >> sure why and how it is

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Steven Rostedt
On Tue, 28 Aug 2018 18:47:33 +0530 Sai Prakash Ranjan wrote: > On 8/27/2018 9:45 PM, Steven Rostedt wrote: > > On Sat, 25 Aug 2018 12:54:07 +0530 > > Sai Prakash Ranjan wrote: > > > > > >> Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not > >> sure why and how it is

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure why and how it is filtered out because I do not see any notrace flag in those functions, maybe that whole

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure why and how it is filtered out because I do not see any notrace flag in those functions, maybe that whole

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-27 Thread Steven Rostedt
On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: > Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not > sure why and how it is filtered out because I do not see any notrace > flag in those functions, maybe that whole directory is filtered out. > So adding this

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-27 Thread Steven Rostedt
On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: > Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not > sure why and how it is filtered out because I do not see any notrace > flag in those functions, maybe that whole directory is filtered out. > So adding this

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-25 Thread Sai Prakash Ranjan
On 8/24/2018 8:59 PM, Kees Cook wrote: On Fri, Aug 24, 2018 at 7:45 AM, Sai Prakash Ranjan wrote: read/write{b,w,l,q} are typically used for reading from memory mapped registers, which can cause hangs if accessed unclocked. Tracing these events can help in debugging various issues faced during

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-25 Thread Sai Prakash Ranjan
On 8/24/2018 8:59 PM, Kees Cook wrote: On Fri, Aug 24, 2018 at 7:45 AM, Sai Prakash Ranjan wrote: read/write{b,w,l,q} are typically used for reading from memory mapped registers, which can cause hangs if accessed unclocked. Tracing these events can help in debugging various issues faced during

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-24 Thread Kees Cook
On Fri, Aug 24, 2018 at 7:45 AM, Sai Prakash Ranjan wrote: > read/write{b,w,l,q} are typically used for reading from memory > mapped registers, which can cause hangs if accessed > unclocked. Tracing these events can help in debugging > various issues faced during initial development. > > We log

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-24 Thread Kees Cook
On Fri, Aug 24, 2018 at 7:45 AM, Sai Prakash Ranjan wrote: > read/write{b,w,l,q} are typically used for reading from memory > mapped registers, which can cause hangs if accessed > unclocked. Tracing these events can help in debugging > various issues faced during initial development. > > We log

[RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-24 Thread Sai Prakash Ranjan
read/write{b,w,l,q} are typically used for reading from memory mapped registers, which can cause hangs if accessed unclocked. Tracing these events can help in debugging various issues faced during initial development. We log this trace information in persistent ram buffer which can be viewed

[RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-24 Thread Sai Prakash Ranjan
read/write{b,w,l,q} are typically used for reading from memory mapped registers, which can cause hangs if accessed unclocked. Tracing these events can help in debugging various issues faced during initial development. We log this trace information in persistent ram buffer which can be viewed