Re: [RFC PATCH v2 2/6] uprobes/x86: Emulate unconditional rip-relative jmp's

2014-04-10 Thread Oleg Nesterov
On 04/10, Denys Vlasenko wrote: > > On 04/09/2014 09:44 PM, Oleg Nesterov wrote: > > uprobes/x86: Emulate unconditional rip-relative jmp's > > I propose "Emulate unconditional relative jmp's" Thanks, will do. And I also agree with your reply to 0/6, will update the code/subjects. > > > +

Re: [RFC PATCH v2 2/6] uprobes/x86: Emulate unconditional rip-relative jmp's

2014-04-10 Thread Denys Vlasenko
On 04/09/2014 09:44 PM, Oleg Nesterov wrote: > uprobes/x86: Emulate unconditional rip-relative jmp's I propose "Emulate unconditional relative jmp's" > + union { > #ifdef CONFIG_X86_64 > - unsigned long rip_rela_target_address; > + unsigned long

Re: [RFC PATCH v2 2/6] uprobes/x86: Emulate unconditional rip-relative jmp's

2014-04-10 Thread Denys Vlasenko
On 04/09/2014 09:44 PM, Oleg Nesterov wrote: uprobes/x86: Emulate unconditional rip-relative jmp's I propose Emulate unconditional relative jmp's + union { #ifdef CONFIG_X86_64 - unsigned long rip_rela_target_address; + unsigned long

Re: [RFC PATCH v2 2/6] uprobes/x86: Emulate unconditional rip-relative jmp's

2014-04-10 Thread Oleg Nesterov
On 04/10, Denys Vlasenko wrote: On 04/09/2014 09:44 PM, Oleg Nesterov wrote: uprobes/x86: Emulate unconditional rip-relative jmp's I propose Emulate unconditional relative jmp's Thanks, will do. And I also agree with your reply to 0/6, will update the code/subjects. + union {

[RFC PATCH v2 2/6] uprobes/x86: Emulate unconditional rip-relative jmp's

2014-04-09 Thread Oleg Nesterov
0xeb and 0xe9. Anything else? TODO: move ->fixup into the union along with rip_rela_target_address. Reported-by: Jonathan Lebon Signed-off-by: Oleg Nesterov --- arch/x86/include/asm/uprobes.h |8 +++- arch/x86/kernel/uprobes.c | 38 ++ 2

[RFC PATCH v2 2/6] uprobes/x86: Emulate unconditional rip-relative jmp's

2014-04-09 Thread Oleg Nesterov
0xeb and 0xe9. Anything else? TODO: move -fixup into the union along with rip_rela_target_address. Reported-by: Jonathan Lebon jle...@redhat.com Signed-off-by: Oleg Nesterov o...@redhat.com --- arch/x86/include/asm/uprobes.h |8 +++- arch/x86/kernel/uprobes.c | 38