Re: [RFC PATCH v2 3/5] mm: Add explicit page decrement in exception path for isolate_lru_pages

2020-08-19 Thread Alexander Duyck
On Wed, Aug 19, 2020 at 12:52 AM Alex Shi wrote: > > > > 在 2020/8/19 下午12:27, Alexander Duyck 写道: > > From: Alexander Duyck > > > > In isolate_lru_pages we have an exception path where if we call > > get_page_unless_zero and that succeeds, but TestClearPageLRU fails we call > > put_page.

Re: [RFC PATCH v2 3/5] mm: Add explicit page decrement in exception path for isolate_lru_pages

2020-08-19 Thread Alex Shi
在 2020/8/19 下午12:27, Alexander Duyck 写道: > From: Alexander Duyck > > In isolate_lru_pages we have an exception path where if we call > get_page_unless_zero and that succeeds, but TestClearPageLRU fails we call > put_page. Normally this would be problematic but due to the way that the > calls

[RFC PATCH v2 3/5] mm: Add explicit page decrement in exception path for isolate_lru_pages

2020-08-18 Thread Alexander Duyck
From: Alexander Duyck In isolate_lru_pages we have an exception path where if we call get_page_unless_zero and that succeeds, but TestClearPageLRU fails we call put_page. Normally this would be problematic but due to the way that the calls are ordered and the fact that we are holding the LRU