Re: [RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-14 Thread Xunlei Pang
Cc Fabio Estevam On 13 January 2015 at 23:44, Xunlei Pang wrote: > From: Xunlei Pang > > rtc_class_ops's set_alarm() shouldn't deal with the alarm date, > as this is handled in the rtc core. > > See rtc_dev_ioctl()'s RTC_ALM_SET and RTC_WKALM_SET cases. > > Signed-off-by: Xunlei Pang > --- >

Re: [RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-14 Thread Xunlei Pang
Cc Fabio Estevam fabio.este...@freescale.com On 13 January 2015 at 23:44, Xunlei Pang xlp...@126.com wrote: From: Xunlei Pang pang.xun...@linaro.org rtc_class_ops's set_alarm() shouldn't deal with the alarm date, as this is handled in the rtc core. See rtc_dev_ioctl()'s RTC_ALM_SET and

Re: [RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:54 +0800 Xunlei Pang wrote: > rtc_class_ops's set_alarm() shouldn't deal with the alarm date, > as this is handled in the rtc core. Please CC the author and ask him. The same applies for the other drivers. -- Best regards, Alessandro Zummo, Tower Technologies -

[RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-13 Thread Xunlei Pang
From: Xunlei Pang rtc_class_ops's set_alarm() shouldn't deal with the alarm date, as this is handled in the rtc core. See rtc_dev_ioctl()'s RTC_ALM_SET and RTC_WKALM_SET cases. Signed-off-by: Xunlei Pang --- drivers/rtc/rtc-mxc.c | 22 -- 1 file changed, 4 insertions(+),

[RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-13 Thread Xunlei Pang
From: Xunlei Pang pang.xun...@linaro.org rtc_class_ops's set_alarm() shouldn't deal with the alarm date, as this is handled in the rtc core. See rtc_dev_ioctl()'s RTC_ALM_SET and RTC_WKALM_SET cases. Signed-off-by: Xunlei Pang pang.xun...@linaro.org --- drivers/rtc/rtc-mxc.c | 22

Re: [RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:54 +0800 Xunlei Pang xlp...@126.com wrote: rtc_class_ops's set_alarm() shouldn't deal with the alarm date, as this is handled in the rtc core. Please CC the author and ask him. The same applies for the other drivers. -- Best regards, Alessandro Zummo, Tower