Re: [RFC PATCH v3] POWER/runtime: refining the rpm_suspend function

2016-01-21 Thread Zhaoyang Huang
On 22 January 2016 at 03:32, Pavel Machek wrote: > >> - goto repeat; >> + >> + /*check expires firstly for auto suspend mode, >> + *if not, just go ahead to the async >> + */ > > English, coding style. >

Re: [RFC PATCH v3] POWER/runtime: refining the rpm_suspend function

2016-01-21 Thread Pavel Machek
> - goto repeat; > + > + /*check expires firstly for auto suspend mode, > + *if not, just go ahead to the async > + */ English, coding style. Pavel

[RFC PATCH v3] POWER/runtime: refining the rpm_suspend function

2016-01-20 Thread Zhaoyang Huang
There are 11 'goto' and 4 'label' within he original rpm_suspend funciton, which make the code a little bit hard for understanding and debugging.Just try to remove all 'goto' and 'label', and split the function into 6 small ones which take one phase of the process each(_rpm_suspend_xxx). By removin