Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On Thu, Oct 8, 2015 at 9:54 PM, Ulf Hansson wrote: > [...] > >>> Thanks for clarifying! >>> >>> You have some differences towards the "standard" sdhci variant, but >>> that doesn't mean you should go off and implement a new driver from >>> scratch, instead you should create a new sdhci variant

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On Thu, Oct 8, 2015 at 9:54 PM, Ulf Hansson wrote: > [...] > >>> Thanks for clarifying! >>> >>> You have some differences towards the "standard" sdhci variant, but >>> that doesn't mean you should go off and implement a new driver from >>> scratch, instead you should

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

[...] >> Thanks for clarifying! >> >> You have some differences towards the "standard" sdhci variant, but >> that doesn't mean you should go off and implement a new driver from >> scratch, instead you should create a new sdhci variant and re-use code >> from the generic sdhci driver. >> >> The

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On Tue, Oct 6, 2015 at 5:18 PM, Ulf Hansson wrote: > +Russell > > On 28 September 2015 at 09:18, Hongtao Wu wrote: >> >> On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson wrote: >>> >>> On 14 August 2015 at 18:55, Hongtao Wu wrote: >>> > the Spreadtrum MMC host driver is used to supply EMMC,

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On Tue, Oct 6, 2015 at 5:18 PM, Ulf Hansson wrote: > +Russell > > On 28 September 2015 at 09:18, Hongtao Wu wrote: >> >> On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson wrote: >>> >>> On 14 August 2015 at 18:55, Hongtao Wu

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

[...] >> Thanks for clarifying! >> >> You have some differences towards the "standard" sdhci variant, but >> that doesn't mean you should go off and implement a new driver from >> scratch, instead you should create a new sdhci variant and re-use code >> from the generic sdhci driver. >> >> The

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

+Russell On 28 September 2015 at 09:18, Hongtao Wu wrote: >>> > > On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson wrote: >> >> On 14 August 2015 at 18:55, Hongtao Wu wrote: >> > the Spreadtrum MMC host driver is used to supply EMMC, SD, and >> > SDIO types of memory cards >> >> Perhaps some more

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

+Russell On 28 September 2015 at 09:18, Hongtao Wu wrote: >>> > > On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson wrote: >> >> On 14 August 2015 at 18:55, Hongtao Wu wrote: >> > the Spreadtrum MMC host driver is used to supply EMMC, SD,

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On 2015/9/28 15:18, Hongtao Wu wrote: >> On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson mailto:ulf.hans...@linaro.org>> wrote: > > On 14 August 2015 at 18:55, Hongtao Wu mailto:wuh...@gmail.com>> wrote: [...] Yes, most of this data can be removed, such as caps, caps2, base_clk. However

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On 2015/9/28 15:18, Hongtao Wu wrote: >> On Thu, Sep 10, 2015 at 9:28 PM, Ulf Hansson > wrote: > > On 14 August 2015 at 18:55, Hongtao Wu > wrote: [...] Yes, most of this data can be

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On 14 August 2015 at 18:55, Hongtao Wu wrote: > the Spreadtrum MMC host driver is used to supply EMMC, SD, and > SDIO types of memory cards Perhaps some more information about the controller. Are there any specific features it support or doesn't support!? Moreover it would be nice to know a bit

Re: [RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

On 14 August 2015 at 18:55, Hongtao Wu wrote: > the Spreadtrum MMC host driver is used to supply EMMC, SD, and > SDIO types of memory cards Perhaps some more information about the controller. Are there any specific features it support or doesn't support!? Moreover it would be

[RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

the Spreadtrum MMC host driver is used to supply EMMC, SD, and SDIO types of memory cards Signed-off-by: Billows Wu(WuHongtao) --- drivers/mmc/host/Kconfig |6 + drivers/mmc/host/Makefile |1 + drivers/mmc/host/sprd_sdhost.c | 1202

[RFC PATCH v3 1/3] mmc: sprd: Add MMC host driver for Spreadtrum SoC

the Spreadtrum MMC host driver is used to supply EMMC, SD, and SDIO types of memory cards Signed-off-by: Billows Wu(WuHongtao) wuh...@gmail.com --- drivers/mmc/host/Kconfig |6 + drivers/mmc/host/Makefile |1 + drivers/mmc/host/sprd_sdhost.c | 1202