Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Al Viro
On Thu, Mar 19, 2015 at 08:14:05PM -0500, Eric W. Biederman wrote: > > Yes please, I'd be more confident if you did this than me, there's > > already enough to worry about with the series. > > Given that this patchset is a security hole waiting to happen I don't > see why Al should bother unless

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Ian Kent
On Thu, 2015-03-19 at 20:14 -0500, Eric W. Biederman wrote: > Ian Kent writes: > > 2> On Thu, 2015-03-19 at 19:47 +, Al Viro wrote: > >> On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: > >> > From: Ian Kent > >> > > >> > The mnt_namespace definition will be needed by the usermode

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Eric W. Biederman
Ian Kent writes: 2> On Thu, 2015-03-19 at 19:47 +, Al Viro wrote: >> On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: >> > From: Ian Kent >> > >> > The mnt_namespace definition will be needed by the usermode helper >> > contained execution implementation, move it to

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Ian Kent
On Thu, 2015-03-19 at 19:47 +, Al Viro wrote: > On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: > > From: Ian Kent > > > > The mnt_namespace definition will be needed by the usermode helper > > contained execution implementation, move it to include/linux/mount.h. > > I really

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Al Viro
On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: > From: Ian Kent > > The mnt_namespace definition will be needed by the usermode helper > contained execution implementation, move it to include/linux/mount.h. I really don't like that. AFAICS, the root of the evil is that fscking

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Ian Kent
On Thu, 2015-03-19 at 19:47 +, Al Viro wrote: On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: From: Ian Kent ik...@redhat.com The mnt_namespace definition will be needed by the usermode helper contained execution implementation, move it to include/linux/mount.h. I really

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Ian Kent
On Thu, 2015-03-19 at 20:14 -0500, Eric W. Biederman wrote: Ian Kent ra...@themaw.net writes: 2 On Thu, 2015-03-19 at 19:47 +, Al Viro wrote: On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: From: Ian Kent ik...@redhat.com The mnt_namespace definition will be needed by

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Eric W. Biederman
Ian Kent ra...@themaw.net writes: 2 On Thu, 2015-03-19 at 19:47 +, Al Viro wrote: On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: From: Ian Kent ik...@redhat.com The mnt_namespace definition will be needed by the usermode helper contained execution implementation, move it

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Al Viro
On Thu, Mar 19, 2015 at 08:14:05PM -0500, Eric W. Biederman wrote: Yes please, I'd be more confident if you did this than me, there's already enough to worry about with the series. Given that this patchset is a security hole waiting to happen I don't see why Al should bother unless there

Re: [RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-19 Thread Al Viro
On Tue, Mar 17, 2015 at 10:45:09AM +0800, Ian Kent wrote: From: Ian Kent ik...@redhat.com The mnt_namespace definition will be needed by the usermode helper contained execution implementation, move it to include/linux/mount.h. I really don't like that. AFAICS, the root of the evil is that

[RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-16 Thread Ian Kent
From: Ian Kent The mnt_namespace definition will be needed by the usermode helper contained execution implementation, move it to include/linux/mount.h. Signed-off-by: Ian Kent Cc: Benjamin Coddington Cc: Al Viro Cc: J. Bruce Fields Cc: David Howells Cc: Trond Myklebust Cc: Oleg Nesterov

[RFC PATCH v4 03/12] vfs - move mnt_namespace definition to linux/mount.h

2015-03-16 Thread Ian Kent
From: Ian Kent ik...@redhat.com The mnt_namespace definition will be needed by the usermode helper contained execution implementation, move it to include/linux/mount.h. Signed-off-by: Ian Kent ik...@redhat.com Cc: Benjamin Coddington bcodd...@redhat.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: J.