Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

> > https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca > > 5a098e > > > > Notice the > > > > Not-Signed-off-by: Andrew Lunn > > > > and the Copyright i added? > > > > In various emails i gave you the basic idea how this should be done, a > > framework > >

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

> > https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca > > 5a098e > > > > Notice the > > > > Not-Signed-off-by: Andrew Lunn > > > > and the Copyright i added? > > > > In various emails i gave you the basic idea how this should be done, a > > framework > > of code, and

RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Andrew, > > > Signed-off-by: Kedareswara rao Appana > > --- > > Thanks a lot Andrew for your inputs. > > Changes for v5: > > --> Fixed return values in the probe as suggested by punnaiah. > > --> Added a mask for the converter speed as suggested by punnaiah. > > +/*

RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Andrew, > > > Signed-off-by: Kedareswara rao Appana > > --- > > Thanks a lot Andrew for your inputs. > > Changes for v5: > > --> Fixed return values in the probe as suggested by punnaiah. > > --> Added a mask for the converter speed as suggested by punnaiah. > > +/* Xilinx GMII2RGMII

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

> Signed-off-by: Kedareswara rao Appana > --- > Thanks a lot Andrew for your inputs. > Changes for v5: > --> Fixed return values in the probe as suggested by punnaiah. > --> Added a mask for the converter speed as suggested by punnaiah. > +/* Xilinx GMII2RGMII Converter driver

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

> Signed-off-by: Kedareswara rao Appana > --- > Thanks a lot Andrew for your inputs. > Changes for v5: > --> Fixed return values in the probe as suggested by punnaiah. > --> Added a mask for the converter speed as suggested by punnaiah. > +/* Xilinx GMII2RGMII Converter driver > + * > + *

RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Florian, Thanks for the review... > > > > This converter sits between the MAC and the external phy MAC <==> > > GMII2RGMII <==> RGMII_PHY > > This looks good, just a few things, see below: Thanks... > > +config XILINX_GMII2RGMII > > + tristate "Xilinx GMII2RGMII converter

RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Florian, Thanks for the review... > > > > This converter sits between the MAC and the external phy MAC <==> > > GMII2RGMII <==> RGMII_PHY > > This looks good, just a few things, see below: Thanks... > > +config XILINX_GMII2RGMII > > + tristate "Xilinx GMII2RGMII converter

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

On 08/09/2016 02:34 AM, Kedareswara rao Appana wrote: > This patch adds support for gmiitorgmii converter. > > The GMII to RGMII IP core provides the Reduced Gigabit Media > Independent Interface (RGMII) between Ethernet physical media > Devices and the Gigabit Ethernet controller. This core can

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

On 08/09/2016 02:34 AM, Kedareswara rao Appana wrote: > This patch adds support for gmiitorgmii converter. > > The GMII to RGMII IP core provides the Reduced Gigabit Media > Independent Interface (RGMII) between Ethernet physical media > Devices and the Gigabit Ethernet controller. This core can

[RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

This patch adds support for gmiitorgmii converter. The GMII to RGMII IP core provides the Reduced Gigabit Media Independent Interface (RGMII) between Ethernet physical media Devices and the Gigabit Ethernet controller. This core can Switch dynamically between the three different speed modes of

[RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

This patch adds support for gmiitorgmii converter. The GMII to RGMII IP core provides the Reduced Gigabit Media Independent Interface (RGMII) between Ethernet physical media Devices and the Gigabit Ethernet controller. This core can Switch dynamically between the three different speed modes of