Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-10-19 Thread Scot Doyle
On Mon, 22 Sep 2014, Peter Hüwe wrote: > Am Montag, 22. September 2014, 19:13:38 schrieb Jason Gunthorpe: > > > > > This does look much nicer, lets use this version. > > > > I think Peter were prefer a new clean patch that superceeds the > > original. > > > > > + if (!priv->irq_tested) { > >

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-10-19 Thread Scot Doyle
On Mon, 22 Sep 2014, Peter Hüwe wrote: Am Montag, 22. September 2014, 19:13:38 schrieb Jason Gunthorpe: This does look much nicer, lets use this version. I think Peter were prefer a new clean patch that superceeds the original. + if (!priv-irq_tested) { I think the sleep

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-22 Thread Scot Doyle
On Mon, 22 Sep 2014, Jason Gunthorpe wrote: On Thu, Sep 11, 2014 at 12:50:00AM +, Scot Doyle wrote: + if (!priv->irq_tested) { I think the sleep and check is still needed here, the IRQ delivery could race relative to the MMIO read of completion, a sleep is the only way we could

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-22 Thread Peter Hüwe
Am Montag, 22. September 2014, 19:13:38 schrieb Jason Gunthorpe: > > This does look much nicer, lets use this version. > > I think Peter were prefer a new clean patch that superceeds the > original. > > > + if (!priv->irq_tested) { > > I think the sleep and check is still needed here, the

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-22 Thread Jason Gunthorpe
On Thu, Sep 11, 2014 at 12:50:00AM +, Scot Doyle wrote: > > On Mon, 8 Sep 2014, Jason Gunthorpe wrote: > > On Tue, Sep 02, 2014 at 08:22:58PM +, Scot Doyle wrote: > > > >> It's spending that time (now 3 seconds) in tpm_tis_send_data. > > > > Due to request_locality? > > The first command

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-22 Thread Jason Gunthorpe
On Thu, Sep 11, 2014 at 12:50:00AM +, Scot Doyle wrote: On Mon, 8 Sep 2014, Jason Gunthorpe wrote: On Tue, Sep 02, 2014 at 08:22:58PM +, Scot Doyle wrote: It's spending that time (now 3 seconds) in tpm_tis_send_data. Due to request_locality? The first command transmitted

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-22 Thread Peter Hüwe
Am Montag, 22. September 2014, 19:13:38 schrieb Jason Gunthorpe: This does look much nicer, lets use this version. I think Peter were prefer a new clean patch that superceeds the original. + if (!priv-irq_tested) { I think the sleep and check is still needed here, the IRQ delivery

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-22 Thread Scot Doyle
On Mon, 22 Sep 2014, Jason Gunthorpe wrote: On Thu, Sep 11, 2014 at 12:50:00AM +, Scot Doyle wrote: + if (!priv-irq_tested) { I think the sleep and check is still needed here, the IRQ delivery could race relative to the MMIO read of completion, a sleep is the only way we could

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-16 Thread Scot Doyle
On Thu, 11 Sep 2014, Scot Doyle wrote: > > On Mon, 8 Sep 2014, Jason Gunthorpe wrote: >> On Tue, Sep 02, 2014 at 08:22:58PM +, Scot Doyle wrote: >> >>> It's spending that time (now 3 seconds) in tpm_tis_send_data. >> >> Due to request_locality? > > The first command transmitted (TPM_CAP_PROP)

Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-16 Thread Scot Doyle
On Thu, 11 Sep 2014, Scot Doyle wrote: On Mon, 8 Sep 2014, Jason Gunthorpe wrote: On Tue, Sep 02, 2014 at 08:22:58PM +, Scot Doyle wrote: It's spending that time (now 3 seconds) in tpm_tis_send_data. Due to request_locality? The first command transmitted (TPM_CAP_PROP) in

[RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-10 Thread Scot Doyle
On Mon, 8 Sep 2014, Jason Gunthorpe wrote: > On Tue, Sep 02, 2014 at 08:22:58PM +, Scot Doyle wrote: > >> It's spending that time (now 3 seconds) in tpm_tis_send_data. > > Due to request_locality? The first command transmitted (TPM_CAP_PROP) in tpm_get_timeouts goes through tpm_tis_send

[RFC PATCH v8] tpm_tis: verify interrupt during init

2014-09-10 Thread Scot Doyle
On Mon, 8 Sep 2014, Jason Gunthorpe wrote: On Tue, Sep 02, 2014 at 08:22:58PM +, Scot Doyle wrote: It's spending that time (now 3 seconds) in tpm_tis_send_data. Due to request_locality? The first command transmitted (TPM_CAP_PROP) in tpm_get_timeouts goes through tpm_tis_send which