RE: [RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Opensource [Steve Twiss]
On: 05 March 2014 15:41 Alessandro Zummo [mailto:a.zu...@towertech.it] wrote >-Original Message- >From: Alessandro Zummo [mailto:a.zu...@towertech.it] >Sent: 05 March 2014 15:41 > >On Wed, 5 Mar 2014 12:25:16 + >"Opensource [Steve Twiss]" wrote: > >> +if (IS_ERR(rtc->rtc_dev)) {

Re: [RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Alessandro Zummo
On Wed, 5 Mar 2014 12:25:16 + "Opensource [Steve Twiss]" wrote: > + if (IS_ERR(rtc->rtc_dev)) { > + ret = PTR_ERR(rtc->rtc_dev); > + goto err; > + } please, return PTR_ERR() > + > + irq_alarm = platform_get_irq_byname(pdev, "ALARM"); > + ret

[RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] Add the RTC driver for DA9063. Signed-off-by: Opensource [Steve Twiss] --- Checks performed with next-20140305/scripts/checkpatch.pl Kconfig total: 0 errors, 21 warnings, 1344 lines checked Makefile total: 0 errors, 0

[RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Opensource [Steve Twiss]
From: Opensource [Steve Twiss] stwiss.opensou...@diasemi.com Add the RTC driver for DA9063. Signed-off-by: Opensource [Steve Twiss] stwiss.opensou...@diasemi.com --- Checks performed with next-20140305/scripts/checkpatch.pl Kconfig total: 0 errors, 21 warnings, 1344 lines

Re: [RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Alessandro Zummo
On Wed, 5 Mar 2014 12:25:16 + Opensource [Steve Twiss] stwiss.opensou...@diasemi.com wrote: + if (IS_ERR(rtc-rtc_dev)) { + ret = PTR_ERR(rtc-rtc_dev); + goto err; + } please, return PTR_ERR() + + irq_alarm = platform_get_irq_byname(pdev,

RE: [RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Opensource [Steve Twiss]
On: 05 March 2014 15:41 Alessandro Zummo [mailto:a.zu...@towertech.it] wrote -Original Message- From: Alessandro Zummo [mailto:a.zu...@towertech.it] Sent: 05 March 2014 15:41 On Wed, 5 Mar 2014 12:25:16 + Opensource [Steve Twiss] stwiss.opensou...@diasemi.com wrote: +if