Re: [RFC V2 PATCH 3/6] cpuidle/ppc: Add timer offload framework to support deep idle states

2013-08-22 Thread Preeti U Murthy
Hi Ben, On 08/22/2013 08:57 AM, Benjamin Herrenschmidt wrote: > On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote: > >> static irqreturn_t timer_action(int irq, void *data) >> { >> -timer_interrupt(); >> +decrementer_timer_interrupt(); >> return IRQ_HANDLED; >> } > > I

Re: [RFC V2 PATCH 3/6] cpuidle/ppc: Add timer offload framework to support deep idle states

2013-08-22 Thread Preeti U Murthy
Hi Ben, On 08/22/2013 08:57 AM, Benjamin Herrenschmidt wrote: On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote: static irqreturn_t timer_action(int irq, void *data) { -timer_interrupt(); +decrementer_timer_interrupt(); return IRQ_HANDLED; } I don't completely

Re: [RFC V2 PATCH 3/6] cpuidle/ppc: Add timer offload framework to support deep idle states

2013-08-21 Thread Benjamin Herrenschmidt
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote: > static irqreturn_t timer_action(int irq, void *data) > { > - timer_interrupt(); > + decrementer_timer_interrupt(); > return IRQ_HANDLED; > } I don't completely understand what you are doing here, but ... > @@ -223,7

Re: [RFC V2 PATCH 3/6] cpuidle/ppc: Add timer offload framework to support deep idle states

2013-08-21 Thread Benjamin Herrenschmidt
On Wed, 2013-08-14 at 17:26 +0530, Preeti U Murthy wrote: static irqreturn_t timer_action(int irq, void *data) { - timer_interrupt(); + decrementer_timer_interrupt(); return IRQ_HANDLED; } I don't completely understand what you are doing here, but ... @@ -223,7 +223,7 @@

[RFC V2 PATCH 3/6] cpuidle/ppc: Add timer offload framework to support deep idle states

2013-08-14 Thread Preeti U Murthy
On ppc, in deep idle states, the local clock event device of CPUs gets switched off. On PowerPC, the local clock event device is called the decrementer. Make use of the broadcast framework to issue interrupts to cpus in deep idle states on their timer events, except that on ppc, we do not have an

[RFC V2 PATCH 3/6] cpuidle/ppc: Add timer offload framework to support deep idle states

2013-08-14 Thread Preeti U Murthy
On ppc, in deep idle states, the local clock event device of CPUs gets switched off. On PowerPC, the local clock event device is called the decrementer. Make use of the broadcast framework to issue interrupts to cpus in deep idle states on their timer events, except that on ppc, we do not have an