Re: [RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

On 2020/11/20 23:25, Andrew Lunn wrote: @@ -310,6 +334,13 @@ int ethnl_set_coalesce(struct sk_buff *skb, struct genl_info *info) ret = dev->ethtool_ops->set_coalesce(dev, ); if (ret < 0) goto out_ops; + + if (ops->set_ext_coalesce) { + ret

Re: [RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

On Fri, 20 Nov 2020 14:24:38 +0800 Huazhong Tan wrote: > + ``ETHTOOL_A_COALESCE_USE_DIM`` boolusing DIM adaptive Sorry, I didn't get into the discussion on v1 in time. I'd prefer this to be an enum (u8 or u32) the values can already be: - device (HW / FW) - driver specific

Re: [RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

> @@ -310,6 +334,13 @@ int ethnl_set_coalesce(struct sk_buff *skb, struct > genl_info *info) > ret = dev->ethtool_ops->set_coalesce(dev, ); > if (ret < 0) > goto out_ops; > + > + if (ops->set_ext_coalesce) { > + ret = ops->set_ext_coalesce(dev,

[RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

Since the information whether the adaptive behavior is implemented by DIM or driver custom is useful, so add new attribute to ETHTOOL_MSG_COALESCE_GET/ETHTOOL_MSG_COALESCE_SET commands to control the type of adaptive coalescing. In order to compatible with ioctl code, add a extended coalescing