Re: [RFC next v1 2/5] gpio: of: parse stmmac PHY reset line specific active-low property

2019-06-09 Thread Linus Walleij
On Sun, Jun 9, 2019 at 11:21 PM Martin Blumenstingl wrote: > my understanding that of_gpio_flags_quirks (which I'm touching with > this patch) is supposed to manage similar quirks to what we have in > stmmac (it also contains some regulator and MMC quirks too). > however, that's exactly the

Re: [RFC next v1 2/5] gpio: of: parse stmmac PHY reset line specific active-low property

2019-06-09 Thread Martin Blumenstingl
Hi Andrew, On Sun, Jun 9, 2019 at 10:38 PM Andrew Lunn wrote: > > On Sun, Jun 09, 2019 at 08:06:18PM +0200, Martin Blumenstingl wrote: > > The stmmac driver currently ignores the GPIO flags which are passed via > > devicetree because it operates with legacy GPIO numbers instead of GPIO > >

Re: [RFC next v1 2/5] gpio: of: parse stmmac PHY reset line specific active-low property

2019-06-09 Thread Andrew Lunn
On Sun, Jun 09, 2019 at 08:06:18PM +0200, Martin Blumenstingl wrote: > The stmmac driver currently ignores the GPIO flags which are passed via > devicetree because it operates with legacy GPIO numbers instead of GPIO > descriptors. Hi Martin I don't think this is the reason. I think historically

[RFC next v1 2/5] gpio: of: parse stmmac PHY reset line specific active-low property

2019-06-09 Thread Martin Blumenstingl
The stmmac driver currently ignores the GPIO flags which are passed via devicetree because it operates with legacy GPIO numbers instead of GPIO descriptors. stmmac assumes that the GPIO is "active HIGH" by default. This can be overwritten by setting "snps,reset-active-low" to make the reset line