Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-09 Thread Olof Johansson
On Tue, Dec 03, 2013 at 09:52:30PM +0800, Hanjun Guo wrote: > On 2013年12月03日 20:27, Linus Walleij wrote: > >On Tue, Dec 3, 2013 at 12:15 PM, Hanjun Guo wrote: > > > >>+ /* if can't be initialised from DT, try ACPI way */ > >>+ if (!arch_timer_get_rate()) > >>+ arch_timer_

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-05 Thread Hanjun Guo
On 2013年12月04日 23:07, Mark Rutland wrote: On Wed, Dec 04, 2013 at 02:27:22PM +, Hanjun Guo wrote: On 2013年12月04日 01:08, Mark Rutland wrote: On Tue, Dec 03, 2013 at 04:41:31PM +, Hanjun Guo wrote: Use arch_timer_acpi_init() on ARM64 to initialise arch timer in ACPI way when DT is not av

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-04 Thread Mark Rutland
On Wed, Dec 04, 2013 at 02:27:22PM +, Hanjun Guo wrote: > On 2013年12月04日 01:08, Mark Rutland wrote: > > On Tue, Dec 03, 2013 at 04:41:31PM +, Hanjun Guo wrote: > >> Use arch_timer_acpi_init() on ARM64 to initialise arch timer > >> in ACPI way when DT is not available. > >> > >> Signed-off-b

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-04 Thread Hanjun Guo
On 2013年12月04日 01:08, Mark Rutland wrote: On Tue, Dec 03, 2013 at 04:41:31PM +, Hanjun Guo wrote: Use arch_timer_acpi_init() on ARM64 to initialise arch timer in ACPI way when DT is not available. Signed-off-by: Hanjun Guo --- arch/arm64/kernel/time.c |4 1 file changed, 4 inse

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-03 Thread Mark Rutland
On Tue, Dec 03, 2013 at 04:41:31PM +, Hanjun Guo wrote: > Use arch_timer_acpi_init() on ARM64 to initialise arch timer > in ACPI way when DT is not available. > > Signed-off-by: Hanjun Guo > --- > arch/arm64/kernel/time.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/

[RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-03 Thread Hanjun Guo
Use arch_timer_acpi_init() on ARM64 to initialise arch timer in ACPI way when DT is not available. Signed-off-by: Hanjun Guo --- arch/arm64/kernel/time.c |4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c index 29c39d5..fb009da 100644 -

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-03 Thread Hanjun Guo
On 2013年12月03日 22:43, Mark Rutland wrote: On Tue, Dec 03, 2013 at 02:13:49PM +, Linus Walleij wrote: On Tue, Dec 3, 2013 at 2:52 PM, Hanjun Guo wrote: I will introduce has_arch_timer_node() as you said and use it as follows: if (has_arch_timer_node()) clocksource_of_init(); esle arch_tim

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-03 Thread Mark Rutland
On Tue, Dec 03, 2013 at 02:13:49PM +, Linus Walleij wrote: > On Tue, Dec 3, 2013 at 2:52 PM, Hanjun Guo wrote: > > > I will introduce has_arch_timer_node() as you said and use > > it as follows: > > > > if (has_arch_timer_node()) > > clocksource_of_init(); > > esle > > arch_timer_acpi_init();

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-03 Thread Linus Walleij
On Tue, Dec 3, 2013 at 2:52 PM, Hanjun Guo wrote: > I will introduce has_arch_timer_node() as you said and use > it as follows: > > if (has_arch_timer_node()) > clocksource_of_init(); > esle > arch_timer_acpi_init(); /* try ACPI way */ > > Is this make sense to you? Sure, go head. Thanks, Linus

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-03 Thread Hanjun Guo
On 2013年12月03日 20:27, Linus Walleij wrote: On Tue, Dec 3, 2013 at 12:15 PM, Hanjun Guo wrote: + /* if can't be initialised from DT, try ACPI way */ + if (!arch_timer_get_rate()) + arch_timer_acpi_init(); + arch_timer_rate = arch_timer_get_rate(); This looks

Re: [RFC part3 PATCH 2/2] ARM64 / clocksource: Use arch_timer_acpi_init()

2013-12-03 Thread Linus Walleij
On Tue, Dec 3, 2013 at 12:15 PM, Hanjun Guo wrote: > + /* if can't be initialised from DT, try ACPI way */ > + if (!arch_timer_get_rate()) > + arch_timer_acpi_init(); > + > arch_timer_rate = arch_timer_get_rate(); This looks a bit fragile. Having a call like arc