Re: [RFC patch 40/41] stacktrace: Remove obsolete functions

2019-04-11 Thread Josh Poimboeuf
On Wed, Apr 10, 2019 at 10:33:20PM -0500, Josh Poimboeuf wrote: > > -#ifdef CONFIG_USER_STACKTRACE_SUPPORT > > +extern void save_stack_trace(struct stack_trace *trace); > > +extern void save_stack_trace_regs(struct pt_regs *regs, > > + struct stack_trace *trace); > >

Re: [RFC patch 40/41] stacktrace: Remove obsolete functions

2019-04-11 Thread Peter Zijlstra
On Wed, Apr 10, 2019 at 10:33:20PM -0500, Josh Poimboeuf wrote: > On Wed, Apr 10, 2019 at 12:28:34PM +0200, Thomas Gleixner wrote: > > +struct stack_trace { > > + unsigned int nr_entries, max_entries; > > + unsigned long *entries; > > + int skip; /* input argument: How many entries to

Re: [RFC patch 40/41] stacktrace: Remove obsolete functions

2019-04-10 Thread Josh Poimboeuf
On Wed, Apr 10, 2019 at 12:28:34PM +0200, Thomas Gleixner wrote: > No more users of the struct stack_trace based interfaces. Remove them. > > Remove the macro stubs for !CONFIG_STACKTRACE as well as they are pointless > because the storage on the call sites is conditional on CONFIG_STACKTRACE >

[RFC patch 40/41] stacktrace: Remove obsolete functions

2019-04-10 Thread Thomas Gleixner
No more users of the struct stack_trace based interfaces. Remove them. Remove the macro stubs for !CONFIG_STACKTRACE as well as they are pointless because the storage on the call sites is conditional on CONFIG_STACKTRACE already. No point to be 'smart'. Signed-off-by: Thomas Gleixner ---