Re: [RFC v1] mm: add page preemption

2019-10-23 Thread Michal Hocko
On Wed 23-10-19 19:53:50, Hillf Danton wrote: > > On Wed, 23 Oct 2019 10:17:29 +0200 Michal Hocko wrote: [...] > > This doesn't really answer my question. > > Why cannot you use memcgs as they are now. > > No prio provided. > > > Why exactly do you need a fixed priority? > > Prio comparison in

Re: [RFC v1] mm: add page preemption

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 22:28:02, Hillf Danton wrote: > > On Tue, 22 Oct 2019 14:42:41 +0200 Michal Hocko wrote: > > > > On Tue 22-10-19 20:14:39, Hillf Danton wrote: > > > > > > On Mon, 21 Oct 2019 14:27:28 +0200 Michal Hocko wrote: > > [...] > > > > Why do we care and which workloads would benefit

Re: [RFC v1] mm: add page preemption

2019-10-22 Thread Michal Hocko
On Tue 22-10-19 20:14:39, Hillf Danton wrote: > > On Mon, 21 Oct 2019 14:27:28 +0200 Michal Hocko wrote: [...] > > Why do we care and which workloads would benefit and how much. > > Page preemption, disabled by default, should be turned on by those > who wish that the performance of their

Re: [RFC v1] mm: add page preemption

2019-10-21 Thread Michal Hocko
On Sun 20-10-19 21:43:04, Hillf Danton wrote: > > Unlike cpu preemption, page preemption would have been a two-edge > option for quite a while. It is added by preventing tasks from > reclaiming as many lru pages as possible from other tasks of > higher priorities. This really begs for more

Re: [RFC v1] mm: add page preemption

2019-10-20 Thread Matthew Wilcox
On Sun, Oct 20, 2019 at 09:43:04PM +0800, Hillf Danton wrote: > First on the page side, page->prio that is used to mirror the prio > of page owner tasks is added, and a couple of helpers for setting, > copying and comparing page->prio to help to add pages to lru. Um, no. struct page is 64 bytes