Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-31 Thread Oscar Salvador
On Wed, Aug 29, 2018 at 11:09:01PM +, Pasha Tatashin wrote: > Hi Oscar, > > I have been studying this patch, and do not see anything bad about it > except that it begs to be split into smaller patches. I think you can > send this work as a series without RFC if this patch is split into 3 or >

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-31 Thread Oscar Salvador
On Wed, Aug 29, 2018 at 11:09:01PM +, Pasha Tatashin wrote: > Hi Oscar, > > I have been studying this patch, and do not see anything bad about it > except that it begs to be split into smaller patches. I think you can > send this work as a series without RFC if this patch is split into 3 or >

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-29 Thread Pasha Tatashin
On 8/17/18 11:41 AM, Oscar Salvador wrote: > From: Oscar Salvador > > Currently, we decrement zone/node spanned_pages when we > remove memory and not when we offline it. > > This, besides of not being consistent with the current code, > implies that we can access steal pages if we never get to

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-29 Thread Pasha Tatashin
On 8/17/18 11:41 AM, Oscar Salvador wrote: > From: Oscar Salvador > > Currently, we decrement zone/node spanned_pages when we > remove memory and not when we offline it. > > This, besides of not being consistent with the current code, > implies that we can access steal pages if we never get to

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-22 Thread David Hildenbrand
On 22.08.2018 09:50, Oscar Salvador wrote: > On Tue, Aug 21, 2018 at 03:17:10PM +0200, David Hildenbrand wrote: >>> add_device_memory is in charge of >> >> I wouldn't use the terminology of onlining/offlining here. That applies >> rather to memory that is exposed to the rest of the system (e.g.

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-22 Thread David Hildenbrand
On 22.08.2018 09:50, Oscar Salvador wrote: > On Tue, Aug 21, 2018 at 03:17:10PM +0200, David Hildenbrand wrote: >>> add_device_memory is in charge of >> >> I wouldn't use the terminology of onlining/offlining here. That applies >> rather to memory that is exposed to the rest of the system (e.g.

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-22 Thread Oscar Salvador
On Tue, Aug 21, 2018 at 03:17:10PM +0200, David Hildenbrand wrote: > > add_device_memory is in charge of > > I wouldn't use the terminology of onlining/offlining here. That applies > rather to memory that is exposed to the rest of the system (e.g. buddy > allocator, has underlying memory block

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-22 Thread Oscar Salvador
On Tue, Aug 21, 2018 at 03:17:10PM +0200, David Hildenbrand wrote: > > add_device_memory is in charge of > > I wouldn't use the terminology of onlining/offlining here. That applies > rather to memory that is exposed to the rest of the system (e.g. buddy > allocator, has underlying memory block

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-21 Thread David Hildenbrand
> add_device_memory is in charge of I wouldn't use the terminology of onlining/offlining here. That applies rather to memory that is exposed to the rest of the system (e.g. buddy allocator, has underlying memory block devices). I guess it is rather a pure setup/teardown of that device memory. >

Re: [RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-21 Thread David Hildenbrand
> add_device_memory is in charge of I wouldn't use the terminology of onlining/offlining here. That applies rather to memory that is exposed to the rest of the system (e.g. buddy allocator, has underlying memory block devices). I guess it is rather a pure setup/teardown of that device memory. >

[RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-17 Thread Oscar Salvador
From: Oscar Salvador Currently, we decrement zone/node spanned_pages when we remove memory and not when we offline it. This, besides of not being consistent with the current code, implies that we can access steal pages if we never get to online that memory. In order to prevent that, we have to

[RFC v2 2/2] mm/memory_hotplug: Shrink spanned pages when offlining memory

2018-08-17 Thread Oscar Salvador
From: Oscar Salvador Currently, we decrement zone/node spanned_pages when we remove memory and not when we offline it. This, besides of not being consistent with the current code, implies that we can access steal pages if we never get to online that memory. In order to prevent that, we have to