Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-23 Thread Nicolas Saenz Julienne
On Tue, 2019-05-21 at 23:43 +0200, Stefan Wahren wrote: > > Nicolas Saenz Julienne hat am 21. Mai 2019 um 17:47 > > geschrieben: > > > > > > Hi Stefan, thanks for your comments! > > > > On Tue, 2019-05-21 at 14:40 +0200, Stefan Wahren wrote: > > > Hi Nicolas, > > > > > > On 20.05.19 14:11, Ste

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-21 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 21. Mai 2019 um 17:47 > geschrieben: > > > Hi Stefan, thanks for your comments! > > On Tue, 2019-05-21 at 14:40 +0200, Stefan Wahren wrote: > > Hi Nicolas, > > > > On 20.05.19 14:11, Stefan Wahren wrote: > > > Hi Nicolas, > > > > > > the following comments a

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-21 Thread Nicolas Saenz Julienne
Hi Stefan, thanks for your comments! On Tue, 2019-05-21 at 14:40 +0200, Stefan Wahren wrote: > Hi Nicolas, > > On 20.05.19 14:11, Stefan Wahren wrote: > > Hi Nicolas, > > > > the following comments applies only in case Eric is fine with the whole > > approach. > > > > On 20.05.19 12:47, Nicolas

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-21 Thread Stefan Wahren
Hi Nicolas, On 20.05.19 14:11, Stefan Wahren wrote: > Hi Nicolas, > > the following comments applies only in case Eric is fine with the whole > approach. > > On 20.05.19 12:47, Nicolas Saenz Julienne wrote: >> Raspberry Pi's firmware, which runs in a dedicated processor, keeps > maybe we should cl

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-21 Thread Nicolas Saenz Julienne
On Tue, 2019-05-21 at 14:14 +0200, Petr Tesarik wrote: > On Tue, 21 May 2019 13:39:31 +0200 > Nicolas Saenz Julienne wrote: > > > Hi Oliver, thanks for the review. > > > > On Mon, 2019-05-20 at 14:43 +0200, Oliver Neukum wrote: > > > On Mo, 2019-05-20 at 12:47 +0200, Nicolas Saenz Julienne wrote

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-21 Thread Petr Tesarik
On Tue, 21 May 2019 13:39:31 +0200 Nicolas Saenz Julienne wrote: > Hi Oliver, thanks for the review. > > On Mon, 2019-05-20 at 14:43 +0200, Oliver Neukum wrote: > > On Mo, 2019-05-20 at 12:47 +0200, Nicolas Saenz Julienne wrote: > > > + * For more information on the firmware interface check: >

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-21 Thread Nicolas Saenz Julienne
Hi Oliver, thanks for the review. On Mon, 2019-05-20 at 14:43 +0200, Oliver Neukum wrote: > On Mo, 2019-05-20 at 12:47 +0200, Nicolas Saenz Julienne wrote: > > + * For more information on the firmware interface check: > > + * https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-20 Thread Oliver Neukum
On Mo, 2019-05-20 at 12:47 +0200, Nicolas Saenz Julienne wrote: > + * For more information on the firmware interface check: > + * https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface > + */ > +struct bcm2835_firmware_prop { > + u32 id; > + u32 val; > + u32 disab

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-20 Thread Stefan Wahren
On 20.05.19 14:11, Stefan Wahren wrote: > > Please verify that the kernel still works (and this clock driver probe) > under the following conditions: > > - CONFIG_RASPBERRYPI_FIRMWARE=n > - CONFIG_RASPBERRYPI_FIRMWARE=m > - older DTBs without patch #1 Sorry, i meant patch #4

Re: [RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-20 Thread Stefan Wahren
Hi Nicolas, the following comments applies only in case Eric is fine with the whole approach. On 20.05.19 12:47, Nicolas Saenz Julienne wrote: > Raspberry Pi's firmware, which runs in a dedicated processor, keeps maybe we should clarify that the firmware is running in the VPU > track of the board

[RFC v2 3/5] clk: bcm2835: use firmware interface to update pllb

2019-05-20 Thread Nicolas Saenz Julienne
Raspberry Pi's firmware, which runs in a dedicated processor, keeps track of the board's temperature and voltage. It's resposible for scaling the CPU frequency whenever it deems the device reached an unsafe state. On top of that the firmware provides an interface which allows Linux to to query the