Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-08 Thread Murali Karicheri
Stephen, Thanks for reviewing this. See my responses below On 11/07/2012 03:05 PM, Stephen Warren wrote: On 11/06/2012 02:47 PM, Murali Karicheri wrote: This is a platform driver for asynchronous external memory interface available on TI SoCs. This driver was previously located inside the

Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-08 Thread Murali Karicheri
Stephen, Thanks for reviewing this. See my responses below On 11/07/2012 03:05 PM, Stephen Warren wrote: On 11/06/2012 02:47 PM, Murali Karicheri wrote: This is a platform driver for asynchronous external memory interface available on TI SoCs. This driver was previously located inside the

Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-07 Thread Stephen Warren
On 11/06/2012 02:47 PM, Murali Karicheri wrote: > This is a platform driver for asynchronous external memory interface > available on TI SoCs. This driver was previously located inside the > mach-davinci folder. As this DaVinci IP is re-used across multiple > family of devices such as c6x,

Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-07 Thread Murali Karicheri
Santhosh, Thanks for the review. Some of the comments below applies to the original code as this driver is moved from mach-davinci to memory. I will fix them though. See below my response. + +curr_cs_data = get_cs_data(chip_cs); +if (curr_cs_data) { +/* for configuration we

Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-07 Thread Murali Karicheri
Santhosh, Thanks for the review. Some of the comments below applies to the original code as this driver is moved from mach-davinci to memory. I will fix them though. See below my response. + +curr_cs_data = get_cs_data(chip_cs); +if (curr_cs_data) { +/* for configuration we

Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-07 Thread Stephen Warren
On 11/06/2012 02:47 PM, Murali Karicheri wrote: This is a platform driver for asynchronous external memory interface available on TI SoCs. This driver was previously located inside the mach-davinci folder. As this DaVinci IP is re-used across multiple family of devices such as c6x, keystone

Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-06 Thread Santosh Shilimkar
On Tuesday 06 November 2012 03:47 PM, Murali Karicheri wrote: This is a platform driver for asynchronous external memory interface available on TI SoCs. This driver was previously located inside the mach-davinci folder. As this DaVinci IP is re-used across multiple family of devices such as c6x,

[RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-06 Thread Murali Karicheri
This is a platform driver for asynchronous external memory interface available on TI SoCs. This driver was previously located inside the mach-davinci folder. As this DaVinci IP is re-used across multiple family of devices such as c6x, keystone etc, the driver is moved to drivers. The driver

[RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-06 Thread Murali Karicheri
This is a platform driver for asynchronous external memory interface available on TI SoCs. This driver was previously located inside the mach-davinci folder. As this DaVinci IP is re-used across multiple family of devices such as c6x, keystone etc, the driver is moved to drivers. The driver

Re: [RFC v2 PATCH 1/2] memory: davinci - add aemif controller platform driver

2012-11-06 Thread Santosh Shilimkar
On Tuesday 06 November 2012 03:47 PM, Murali Karicheri wrote: This is a platform driver for asynchronous external memory interface available on TI SoCs. This driver was previously located inside the mach-davinci folder. As this DaVinci IP is re-used across multiple family of devices such as c6x,