Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-18 Thread Viresh Kumar
On 18-10-19, 11:26, Rafael J. Wysocki wrote: > On Fri, Oct 18, 2019 at 11:24 AM Viresh Kumar wrote: > > > > On 18-10-19, 10:30, Rafael J. Wysocki wrote: > > > On Fri, Oct 18, 2019 at 10:27 AM Viresh Kumar > > > wrote: > > > > > > > > On 18-10-19, 10:24, Rafael J. Wysocki wrote: > > > > > On Fri,

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-18 Thread Rafael J. Wysocki
On Fri, Oct 18, 2019 at 11:24 AM Viresh Kumar wrote: > > On 18-10-19, 10:30, Rafael J. Wysocki wrote: > > On Fri, Oct 18, 2019 at 10:27 AM Viresh Kumar > > wrote: > > > > > > On 18-10-19, 10:24, Rafael J. Wysocki wrote: > > > > On Fri, Oct 18, 2019 at 7:44 AM Viresh Kumar > > > > wrote: > > >

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-18 Thread Viresh Kumar
On 18-10-19, 10:30, Rafael J. Wysocki wrote: > On Fri, Oct 18, 2019 at 10:27 AM Viresh Kumar wrote: > > > > On 18-10-19, 10:24, Rafael J. Wysocki wrote: > > > On Fri, Oct 18, 2019 at 7:44 AM Viresh Kumar > > > wrote: > > > > > > > > On 17-10-19, 18:34, Rafael J. Wysocki wrote: > > > > > [BTW, Vi

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-18 Thread Rafael J. Wysocki
On Fri, Oct 18, 2019 at 10:27 AM Viresh Kumar wrote: > > On 18-10-19, 10:24, Rafael J. Wysocki wrote: > > On Fri, Oct 18, 2019 at 7:44 AM Viresh Kumar > > wrote: > > > > > > On 17-10-19, 18:34, Rafael J. Wysocki wrote: > > > > [BTW, Viresh, it looks like cpufreq_set_policy() should still ensure

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-18 Thread Viresh Kumar
On 18-10-19, 10:24, Rafael J. Wysocki wrote: > On Fri, Oct 18, 2019 at 7:44 AM Viresh Kumar wrote: > > > > On 17-10-19, 18:34, Rafael J. Wysocki wrote: > > > [BTW, Viresh, it looks like cpufreq_set_policy() should still ensure > > > that the new min is less than the new max, because the QoS doesn'

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-18 Thread Rafael J. Wysocki
On Fri, Oct 18, 2019 at 7:44 AM Viresh Kumar wrote: > > On 17-10-19, 18:34, Rafael J. Wysocki wrote: > > [BTW, Viresh, it looks like cpufreq_set_policy() should still ensure > > that the new min is less than the new max, because the QoS doesn't do > > that.] > > The ->verify() callback does that f

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-17 Thread Viresh Kumar
On 17-10-19, 18:34, Rafael J. Wysocki wrote: > [BTW, Viresh, it looks like cpufreq_set_policy() should still ensure > that the new min is less than the new max, because the QoS doesn't do > that.] The ->verify() callback does that for us I believe. -- viresh

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-17 Thread Sudeep Holla
On Wed, Oct 16, 2019 at 03:23:43PM +0100, Sudeep Holla wrote: > On Wed, Oct 16, 2019 at 12:37:58PM +0200, Rafael J. Wysocki wrote: > > Hi All, > > > > The motivation for this series is to address the problem discussed here: > > > > https://lore.kernel.org/linux-pm/5ad2624194baa2f53acc1f1e627eb7684c

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-17 Thread Sudeep Holla
On Thu, Oct 17, 2019 at 06:34:28PM +0200, Rafael J. Wysocki wrote: > On Thu, Oct 17, 2019 at 12:00 PM Sudeep Holla wrote: > > > > On Thu, Oct 17, 2019 at 03:27:25PM +0530, Viresh Kumar wrote: > > > On 16-10-19, 15:23, Sudeep Holla wrote: > > > > Thanks for the spinning these patches so quickly. >

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-17 Thread Rafael J. Wysocki
On Thu, Oct 17, 2019 at 12:00 PM Sudeep Holla wrote: > > On Thu, Oct 17, 2019 at 03:27:25PM +0530, Viresh Kumar wrote: > > On 16-10-19, 15:23, Sudeep Holla wrote: > > > Thanks for the spinning these patches so quickly. > > > > > > I did give it a spin, but unfortunately it doesn't fix the bug I re

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-17 Thread Sudeep Holla
On Thu, Oct 17, 2019 at 03:27:25PM +0530, Viresh Kumar wrote: > On 16-10-19, 15:23, Sudeep Holla wrote: > > Thanks for the spinning these patches so quickly. > > > > I did give it a spin, but unfortunately it doesn't fix the bug I reported. > > So I looked at my bug report in detail and looks like

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-17 Thread Viresh Kumar
On 16-10-19, 15:23, Sudeep Holla wrote: > Thanks for the spinning these patches so quickly. > > I did give it a spin, but unfortunately it doesn't fix the bug I reported. > So I looked at my bug report in detail and looks like the cpufreq_driver > variable is set to NULL at that point and it fails

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-17 Thread Viresh Kumar
On 16-10-19, 12:37, Rafael J. Wysocki wrote: > Hi All, > > The motivation for this series is to address the problem discussed here: > > https://lore.kernel.org/linux-pm/5ad2624194baa2f53acc1f1e627eb7684c577a19.1562210705.git.viresh.ku...@linaro.org/T/#md2d89e95906b8c91c15f582146173dce2e86e99f >

Re: [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-16 Thread Sudeep Holla
On Wed, Oct 16, 2019 at 12:37:58PM +0200, Rafael J. Wysocki wrote: > Hi All, > > The motivation for this series is to address the problem discussed here: > > https://lore.kernel.org/linux-pm/5ad2624194baa2f53acc1f1e627eb7684c577a19.1562210705.git.viresh.ku...@linaro.org/T/#md2d89e95906b8c91c15f5821

[RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

2019-10-16 Thread Rafael J. Wysocki
Hi All, The motivation for this series is to address the problem discussed here: https://lore.kernel.org/linux-pm/5ad2624194baa2f53acc1f1e627eb7684c577a19.1562210705.git.viresh.ku...@linaro.org/T/#md2d89e95906b8c91c15f582146173dce2e86e99f and also reported here: https://lore.kernel.org/linux-pm