Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-30 Thread Leo Yan
On Wed, May 30, 2018 at 11:39:00PM +0800, Leo Yan wrote: > Hi Mike, > > On Wed, May 30, 2018 at 04:04:34PM +0100, Mike Leach wrote: > > [...] > > > >>> + /* Generate sample for exception packet */ > > >>> + if (etmq->prev_packet->exc == true) > > >>> +

Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-30 Thread Leo Yan
On Wed, May 30, 2018 at 11:39:00PM +0800, Leo Yan wrote: > Hi Mike, > > On Wed, May 30, 2018 at 04:04:34PM +0100, Mike Leach wrote: > > [...] > > > >>> + /* Generate sample for exception packet */ > > >>> + if (etmq->prev_packet->exc == true) > > >>> +

Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-29 Thread Leo Yan
Hi Mathieu, On Tue, May 29, 2018 at 10:04:49AM -0600, Mathieu Poirier wrote: [...] > > As now this patch is big with more complex logic, so I consider to > > split it into small patches: > > > > - Define CS_ETM_INVAL_ADDR; > > - Fix for CS_ETM_TRACE_ON packet; > > - Fix for exception packet; >

Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-29 Thread Leo Yan
Hi Mathieu, On Tue, May 29, 2018 at 10:04:49AM -0600, Mathieu Poirier wrote: [...] > > As now this patch is big with more complex logic, so I consider to > > split it into small patches: > > > > - Define CS_ETM_INVAL_ADDR; > > - Fix for CS_ETM_TRACE_ON packet; > > - Fix for exception packet; >

Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-28 Thread Leo Yan
Hi Mathieu, On Mon, May 28, 2018 at 04:13:47PM -0600, Mathieu Poirier wrote: > Leo and/or Robert, > > On Mon, May 28, 2018 at 04:45:00PM +0800, Leo Yan wrote: > > Commit e573e978fb12 ("perf cs-etm: Inject capabilitity for CoreSight > > traces") reworks the samples generation flow from CoreSight

Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-28 Thread Leo Yan
Hi Mathieu, On Mon, May 28, 2018 at 04:13:47PM -0600, Mathieu Poirier wrote: > Leo and/or Robert, > > On Mon, May 28, 2018 at 04:45:00PM +0800, Leo Yan wrote: > > Commit e573e978fb12 ("perf cs-etm: Inject capabilitity for CoreSight > > traces") reworks the samples generation flow from CoreSight

Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-28 Thread Mathieu Poirier
Leo and/or Robert, On Mon, May 28, 2018 at 04:45:00PM +0800, Leo Yan wrote: > Commit e573e978fb12 ("perf cs-etm: Inject capabilitity for CoreSight > traces") reworks the samples generation flow from CoreSight trace to > match the correct format so Perf report tool can display the samples >

Re: [RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-28 Thread Mathieu Poirier
Leo and/or Robert, On Mon, May 28, 2018 at 04:45:00PM +0800, Leo Yan wrote: > Commit e573e978fb12 ("perf cs-etm: Inject capabilitity for CoreSight > traces") reworks the samples generation flow from CoreSight trace to > match the correct format so Perf report tool can display the samples >

[RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-28 Thread Leo Yan
Commit e573e978fb12 ("perf cs-etm: Inject capabilitity for CoreSight traces") reworks the samples generation flow from CoreSight trace to match the correct format so Perf report tool can display the samples properly. But the change has side effect for branch packet handling, it only generate

[RFT v3 1/4] perf cs-etm: Generate branch sample for missed packets

2018-05-28 Thread Leo Yan
Commit e573e978fb12 ("perf cs-etm: Inject capabilitity for CoreSight traces") reworks the samples generation flow from CoreSight trace to match the correct format so Perf report tool can display the samples properly. But the change has side effect for branch packet handling, it only generate