Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-09-04 Thread Joerg Vehlow
I just happen to be analyzing an error in the kernel if ipcomp is used with rt patches. The reason was the meissing lock around the scratch buffer for the compress call. Now that I have applied Juris fix, I get another error: [ 139.717259] BUG: unable to handle kernel NULL pointer dereference

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-21 Thread bige...@linutronix.de
On 2019-08-21 08:44:22 [+0200], Juri Lelli wrote: > > Hi Juri, currently if the mail subject has RFC, we will test it but send > > report > > privately to author only. > > OK. But, my email had "RT" and not "RFC" in the subject (since it is > meant for one of the PREEMPT_RT stable trees [1]).

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-21 Thread Juri Lelli
On 21/08/19 01:43, Li, Philip wrote: > > Subject: Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with > > local_lock > > > > Hi, > > > > On 20/08/19 13:35, kbuild test robot wrote: > > > Hi Juri, > > > > > > Thank

RE: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-20 Thread Li, Philip
> Subject: Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with > local_lock > > Hi, > > On 20/08/19 13:35, kbuild test robot wrote: > > Hi Juri, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-20 Thread Sebastian Andrzej Siewior
On 2019-08-19 14:27:31 [+0200], Juri Lelli wrote: > This v2 applies to v4.19.59-rt24. Looks good, I suggest to apply this to v4.19 and earlier. For v5.2 and later (including upstream) please send a patch to simply replace get_cpu() with smp_processor_id(). The reason is that get_cpu() will not

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-20 Thread Juri Lelli
On 19/08/19 15:57, Steven Rostedt wrote: > On Mon, 19 Aug 2019 14:27:31 +0200 > Juri Lelli wrote: > > > The following BUG has been reported while running ipsec tests. > > Thanks! > > I'm still in the process of backporting patches to fix some bugs that > showed up with the latest merge of

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-20 Thread Juri Lelli
Hi, On 20/08/19 13:35, kbuild test robot wrote: > Hi Juri, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [cannot apply to v5.3-rc5 next-20190819] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-19 Thread kbuild test robot
Hi Juri, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc5 next-20190819] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-19 Thread Steven Rostedt
On Mon, 19 Aug 2019 14:27:31 +0200 Juri Lelli wrote: > The following BUG has been reported while running ipsec tests. Thanks! I'm still in the process of backporting patches to fix some bugs that showed up with the latest merge of upstream stable. I'll add this to the queue to add. -- Steve

[RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-19 Thread Juri Lelli
The following BUG has been reported while running ipsec tests. BUG: scheduling while atomic: irq/78-eno3-rx-/12023/0x0002 Modules linked in: ipcomp xfrm_ipcomp ... Preemption disabled at: [] ipcomp_input+0xd0/0x9a0 [xfrm_ipcomp] CPU: 1 PID: 12023 Comm: irq/78-eno3-rx- Kdump: loaded Not