Re: [Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-23 Thread Pedro Vanzella
On 8/23/19 10:32 AM, Benjamin Tissoires wrote: On Fri, Aug 23, 2019 at 4:22 PM Pedro Vanzella wrote: Hi Benjamin, On 8/23/19 4:25 AM, Benjamin Tissoires wrote: Hi Pedro, On Thu, Aug 22, 2019 at 10:19 PM Pedro Vanzella wrote: Resumitting this after having rebased it against the latest

Re: [Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-23 Thread Benjamin Tissoires
On Fri, Aug 23, 2019 at 4:48 PM Filipe Laíns wrote: > > On Fri, 2019-08-23 at 16:32 +0200, Benjamin Tissoires wrote: > > The problem I have with quirks, and that I explained to Filipe on IRC > > is that this is kernel ABI. Even if there is a very low chance we have > > someone using this,

Re: [Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-23 Thread Filipe Laíns
On Fri, 2019-08-23 at 16:32 +0200, Benjamin Tissoires wrote: > The problem I have with quirks, and that I explained to Filipe on IRC > is that this is kernel ABI. Even if there is a very low chance we have > someone using this, re-using the same drv_data bit in the future might > break someone's

Re: [Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-23 Thread Benjamin Tissoires
On Fri, Aug 23, 2019 at 4:22 PM Pedro Vanzella wrote: > > Hi Benjamin, > > On 8/23/19 4:25 AM, Benjamin Tissoires wrote: > > Hi Pedro, > > > > On Thu, Aug 22, 2019 at 10:19 PM Pedro Vanzella > > wrote: > >> > >> Resumitting this after having rebased it against the latest changes. > > > > thanks

Re: [Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-23 Thread Filipe Laíns
On Fri, 2019-08-23 at 10:22 -0400, Pedro Vanzella wrote: > I actually resubmitted by Filipe's request, since the patches weren't > applying cleanly anymore. The idea was to apply these patches and in the > future refactor the code to use the feature discovery routines. Yes, I want to refactor

Re: [Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-23 Thread Pedro Vanzella
Hi Benjamin, On 8/23/19 4:25 AM, Benjamin Tissoires wrote: Hi Pedro, On Thu, Aug 22, 2019 at 10:19 PM Pedro Vanzella wrote: Resumitting this after having rebased it against the latest changes. thanks for resubmitting. Sorry I wasn't able to provide feedback on the last revision No

Re: [Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-23 Thread Benjamin Tissoires
Hi Pedro, On Thu, Aug 22, 2019 at 10:19 PM Pedro Vanzella wrote: > > Resumitting this after having rebased it against the latest changes. thanks for resubmitting. Sorry I wasn't able to provide feedback on the last revision > > The gaming line of Logitech devices doesn't use the old hidpp20 >

[Resubmit] Read battery voltage from Logitech Gaming mice

2019-08-22 Thread Pedro Vanzella
Resumitting this after having rebased it against the latest changes. The gaming line of Logitech devices doesn't use the old hidpp20 feature for battery level reporting. Instead, they report the current voltage of the battery, in millivolts. This patch set handles this case by adding a quirk to