Re: [SIL2review] [PATCH] fixdep: free memory on second error path of do_config_file

2017-12-27 Thread Lukas Bulwahn
On Mon, 18 Dec 2017, Masahiro Yamada wrote: 2017-12-15 17:23 GMT+09:00 Nicholas Mc Guire : On Thu, Dec 14, 2017 at 08:54:10PM +0100, Lukas Bulwahn wrote: Commit dee81e988674 ("fixdep: faster CONFIG_ search") introduces the memory leak when `map = mmap(...)` was replaced

Re: [SIL2review] [PATCH] fixdep: free memory on second error path of do_config_file

2017-12-27 Thread Lukas Bulwahn
On Mon, 18 Dec 2017, Masahiro Yamada wrote: 2017-12-15 17:23 GMT+09:00 Nicholas Mc Guire : On Thu, Dec 14, 2017 at 08:54:10PM +0100, Lukas Bulwahn wrote: Commit dee81e988674 ("fixdep: faster CONFIG_ search") introduces the memory leak when `map = mmap(...)` was replaced with `map =

Re: [SIL2review] [PATCH] fixdep: free memory on second error path of do_config_file

2017-12-18 Thread Masahiro Yamada
2017-12-15 17:23 GMT+09:00 Nicholas Mc Guire : > On Thu, Dec 14, 2017 at 08:54:10PM +0100, Lukas Bulwahn wrote: >> Commit dee81e988674 ("fixdep: faster CONFIG_ search") introduces the memory >> leak when `map = mmap(...)` was replaced with `map = malloc(...)` and >> `read(fd,

Re: [SIL2review] [PATCH] fixdep: free memory on second error path of do_config_file

2017-12-18 Thread Masahiro Yamada
2017-12-15 17:23 GMT+09:00 Nicholas Mc Guire : > On Thu, Dec 14, 2017 at 08:54:10PM +0100, Lukas Bulwahn wrote: >> Commit dee81e988674 ("fixdep: faster CONFIG_ search") introduces the memory >> leak when `map = mmap(...)` was replaced with `map = malloc(...)` and >> `read(fd, map, ...)`. It

Re: [SIL2review] [PATCH] fixdep: free memory on second error path of do_config_file

2017-12-15 Thread Nicholas Mc Guire
On Thu, Dec 14, 2017 at 08:54:10PM +0100, Lukas Bulwahn wrote: > Commit dee81e988674 ("fixdep: faster CONFIG_ search") introduces the memory > leak when `map = mmap(...)` was replaced with `map = malloc(...)` and > `read(fd, map, ...)`. It introduces a new second error path, which does not > free

Re: [SIL2review] [PATCH] fixdep: free memory on second error path of do_config_file

2017-12-15 Thread Nicholas Mc Guire
On Thu, Dec 14, 2017 at 08:54:10PM +0100, Lukas Bulwahn wrote: > Commit dee81e988674 ("fixdep: faster CONFIG_ search") introduces the memory > leak when `map = mmap(...)` was replaced with `map = malloc(...)` and > `read(fd, map, ...)`. It introduces a new second error path, which does not > free