Re: [Sound-open-firmware] [PATCH v2 1/5] ASoC: SOF: imx: Add i.MX8 HW support

2019-07-24 Thread Daniel Baluta
On Wed, Jul 24, 2019 at 11:32 AM Lucas Stach wrote: > > Hi Daniel, > > Am Mittwoch, den 24.07.2019, 09:54 +0300 schrieb Daniel Baluta: > > On Tue, Jul 23, 2019 at 6:18 PM Pierre-Louis Bossart > [...] > > > > > Also are all the resources device-managed, I don't see a remove()? > > > > Good catch

Re: [Sound-open-firmware] [PATCH v2 1/5] ASoC: SOF: imx: Add i.MX8 HW support

2019-07-24 Thread Lucas Stach
Hi Daniel, Am Mittwoch, den 24.07.2019, 09:54 +0300 schrieb Daniel Baluta: > On Tue, Jul 23, 2019 at 6:18 PM Pierre-Louis Bossart [...] > > > Also are all the resources device-managed, I don't see a remove()? > > Good catch for pm stuff. We mostly didn't care about remove because > drivers are

Re: [Sound-open-firmware] [PATCH v2 1/5] ASoC: SOF: imx: Add i.MX8 HW support

2019-07-24 Thread Daniel Baluta
On Tue, Jul 23, 2019 at 6:18 PM Pierre-Louis Bossart wrote: > > > > diff --git a/sound/soc/sof/imx/Makefile b/sound/soc/sof/imx/Makefile > > new file mode 100644 > > index ..c69237971da5 > > --- /dev/null > > +++ b/sound/soc/sof/imx/Makefile > > @@ -0,0 +1,7 @@ > > +#

Re: [Sound-open-firmware] [PATCH v2 1/5] ASoC: SOF: imx: Add i.MX8 HW support

2019-07-23 Thread Pierre-Louis Bossart
diff --git a/sound/soc/sof/imx/Makefile b/sound/soc/sof/imx/Makefile new file mode 100644 index ..c69237971da5 --- /dev/null +++ b/sound/soc/sof/imx/Makefile @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) + +ccflags-y += -DDEBUG this should be removed or in