Re: [Suggestion] PowerPC: kernel: memory access violation when rtas_data_buf contents are more than 1026

2013-04-22 Thread Chen Gang
On 2013年04月23日 08:31, Benjamin Herrenschmidt wrote: > On Thu, 2013-04-18 at 12:45 +0800, Chen Gang wrote: >> Hello Maintainers: >> >> >> in arch/powerpc/kernel/lparcfg.c, parse_system_parameter_string() >> >> need set '\0' for 'local_buffer'. >> >> the reason is: >> SPLPAR_MAXLENGTH is 1026

Re: [Suggestion] PowerPC: kernel: memory access violation when rtas_data_buf contents are more than 1026

2013-04-22 Thread Benjamin Herrenschmidt
On Thu, 2013-04-18 at 12:45 +0800, Chen Gang wrote: > Hello Maintainers: > > > in arch/powerpc/kernel/lparcfg.c, parse_system_parameter_string() > > need set '\0' for 'local_buffer'. > > the reason is: > SPLPAR_MAXLENGTH is 1026, RTAS_DATA_BUF_SIZE is 4096 > the contents of rtas_dat

[Suggestion] PowerPC: kernel: memory access violation when rtas_data_buf contents are more than 1026

2013-04-17 Thread Chen Gang
Hello Maintainers: in arch/powerpc/kernel/lparcfg.c, parse_system_parameter_string() need set '\0' for 'local_buffer'. the reason is: SPLPAR_MAXLENGTH is 1026, RTAS_DATA_BUF_SIZE is 4096 the contents of rtas_data_buf may truncated in memcpy (line 301). if contents are truncated