Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-03 Thread yalin wang
> On Aug 4, 2015, at 10:27, Joe Perches wrote: > > On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote: >> Ping ? >>> On Aug 3, 2015, at 16:56, yalin wang wrote: >>> >>> On Aug 3, 2015, at 16:03, Joe Perches wrote: On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: >>

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-03 Thread Joe Perches
On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote: > Ping ? > > On Aug 3, 2015, at 16:56, yalin wang wrote: > > > > > >> On Aug 3, 2015, at 16:03, Joe Perches wrote: > >> > >> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: > On Aug 3, 2015, at 04:25, Joe Perches wrote: >

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-03 Thread yalin wang
Ping ? > On Aug 3, 2015, at 16:56, yalin wang wrote: > > >> On Aug 3, 2015, at 16:03, Joe Perches wrote: >> >> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: On Aug 3, 2015, at 04:25, Joe Perches wrote: Correct misuse of 0x%d in logging messages. >> [] >>> why

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-03 Thread yalin wang
> On Aug 3, 2015, at 16:03, Joe Perches wrote: > > On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: >>> On Aug 3, 2015, at 04:25, Joe Perches wrote: >>> >>> Correct misuse of 0x%d in logging messages. >>> > [] >> why not use like this : dev_dbg(>pdev->dev, " Max outstanding >>

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: > > On Aug 3, 2015, at 04:25, Joe Perches wrote: > > > > Correct misuse of 0x%d in logging messages. > > [] > why not use like this : dev_dbg(>pdev->dev, " Max outstanding > commands = %#x\n” ? > %#x will add 0x prefix automatically .

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-03 Thread yalin wang
> On Aug 3, 2015, at 04:25, Joe Perches wrote: > > Correct misuse of 0x%d in logging messages. > > Signed-off-by: Joe Perches > --- > drivers/block/DAC960.c | 4 ++-- > drivers/block/cciss.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/DAC960.c

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-03 Thread Johannes Thumshirn
Joe Perches writes: > Correct misuse of 0x%d in logging messages. > > Signed-off-by: Joe Perches > --- > drivers/block/DAC960.c | 4 ++-- > drivers/block/cciss.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c > index

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread yalin wang
Ping ? On Aug 3, 2015, at 16:56, yalin wang yalin.wang2...@gmail.com wrote: On Aug 3, 2015, at 16:03, Joe Perches j...@perches.com wrote: On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: On Aug 3, 2015, at 04:25, Joe Perches j...@perches.com wrote: Correct misuse of 0x%d in

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread Joe Perches
On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote: Ping ? On Aug 3, 2015, at 16:56, yalin wang yalin.wang2...@gmail.com wrote: On Aug 3, 2015, at 16:03, Joe Perches j...@perches.com wrote: On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: On Aug 3, 2015, at 04:25, Joe

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread yalin wang
On Aug 4, 2015, at 10:27, Joe Perches j...@perches.com wrote: On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote: Ping ? On Aug 3, 2015, at 16:56, yalin wang yalin.wang2...@gmail.com wrote: On Aug 3, 2015, at 16:03, Joe Perches j...@perches.com wrote: On Mon, 2015-08-03 at 15:25

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread yalin wang
On Aug 3, 2015, at 16:03, Joe Perches j...@perches.com wrote: On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: On Aug 3, 2015, at 04:25, Joe Perches j...@perches.com wrote: Correct misuse of 0x%d in logging messages. [] why not use like this : dev_dbg(h-pdev-dev,Max

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread Johannes Thumshirn
Joe Perches j...@perches.com writes: Correct misuse of 0x%d in logging messages. Signed-off-by: Joe Perches j...@perches.com --- drivers/block/DAC960.c | 4 ++-- drivers/block/cciss.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/DAC960.c

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread Joe Perches
On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: On Aug 3, 2015, at 04:25, Joe Perches j...@perches.com wrote: Correct misuse of 0x%d in logging messages. [] why not use like this : dev_dbg(h-pdev-dev,Max outstanding commands = %#x\n” ? %#x will add 0x prefix automatically

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-03 Thread yalin wang
On Aug 3, 2015, at 04:25, Joe Perches j...@perches.com wrote: Correct misuse of 0x%d in logging messages. Signed-off-by: Joe Perches j...@perches.com --- drivers/block/DAC960.c | 4 ++-- drivers/block/cciss.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[TRIVIAL PATCH] block: Correct misuses of 0x%

2015-08-02 Thread Joe Perches
Correct misuse of 0x%d in logging messages. Signed-off-by: Joe Perches --- drivers/block/DAC960.c | 4 ++-- drivers/block/cciss.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 811e11c..d9b32f2 100644 ---

[TRIVIAL PATCH] block: Correct misuses of 0x%decimal

2015-08-02 Thread Joe Perches
Correct misuse of 0x%d in logging messages. Signed-off-by: Joe Perches j...@perches.com --- drivers/block/DAC960.c | 4 ++-- drivers/block/cciss.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 811e11c..d9b32f2 100644