Re: [TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread Andrew Morton
moreau francis <[EMAIL PROTECTED]> wrote: > > By the way, is it safe in "n_tty_receive_overrun" to > call > "printk" ? because the former can be called from IT > context... yup. printk() is safe from all contexts except NMI. - To unsubscribe from this list: send the line "unsubscribe

Re: [TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread moreau francis
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > moreau francis <[EMAIL PROTECTED]> wrote: > > How does this look? > It works well though I haven't tested the second correction. But it looks good... By the way, is it safe in "n_tty_receive_overrun" to call "printk" ? because the former can be

Re: [TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread Andrew Morton
moreau francis <[EMAIL PROTECTED]> wrote: > > I noticed that TTY is not able to notify overrun issue > in "n_tty_receive_overrun". Actually it's because of > "time_before" macro which tests "tty->overrun_time" > (equals to 0) against "jiffies - HZ" (something very > big > after booting). >

[TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread moreau francis
I noticed that TTY is not able to notify overrun issue in "n_tty_receive_overrun". Actually it's because of "time_before" macro which tests "tty->overrun_time" (equals to 0) against "jiffies - HZ" (something very big after booting). I guess a simple way to solve it, is to initialize

[TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread moreau francis
I noticed that TTY is not able to notify overrun issue in n_tty_receive_overrun. Actually it's because of time_before macro which tests tty-overrun_time (equals to 0) against jiffies - HZ (something very big after booting). I guess a simple way to solve it, is to initialize tty-overrun_time to

Re: [TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread Andrew Morton
moreau francis [EMAIL PROTECTED] wrote: I noticed that TTY is not able to notify overrun issue in n_tty_receive_overrun. Actually it's because of time_before macro which tests tty-overrun_time (equals to 0) against jiffies - HZ (something very big after booting). I guess a simple

Re: [TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread moreau francis
--- Andrew Morton [EMAIL PROTECTED] wrote: moreau francis [EMAIL PROTECTED] wrote: How does this look? It works well though I haven't tested the second correction. But it looks good... By the way, is it safe in n_tty_receive_overrun to call printk ? because the former can be called from IT

Re: [TTY] overrun notify issue during 5 minutes after booting

2005-03-14 Thread Andrew Morton
moreau francis [EMAIL PROTECTED] wrote: By the way, is it safe in n_tty_receive_overrun to call printk ? because the former can be called from IT context... yup. printk() is safe from all contexts except NMI. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the