Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

On Sun, Dec 11, 2016 at 5:15 PM, Marek Vasut wrote: >> ret = -ENOMEM; >> + base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); >> + if (!base) >> + return ret; > > I think return -ENOMEM right away won't hurt here. Also, dev_err() >

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

On Sun, Dec 11, 2016 at 5:15 PM, Marek Vasut wrote: >> ret = -ENOMEM; >> + base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); >> + if (!base) >> + return ret; > > I think return -ENOMEM right away won't hurt here. Also, dev_err() > explaining the failure would be

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

Yes, We are returning -ENOMEM, ret is initialized to -ENOMEM. As per your concern, I have added dev_err failure message. Thanks -Arvind On Monday 12 December 2016 12:45 AM, Marek Vasut wrote: On 12/11/2016 07:01 PM, Arvind Yadav wrote: Here, If devm_ioremap will fail. It will return NULL.

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

Yes, We are returning -ENOMEM, ret is initialized to -ENOMEM. As per your concern, I have added dev_err failure message. Thanks -Arvind On Monday 12 December 2016 12:45 AM, Marek Vasut wrote: On 12/11/2016 07:01 PM, Arvind Yadav wrote: Here, If devm_ioremap will fail. It will return NULL.

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

On 12/11/2016 07:01 PM, Arvind Yadav wrote: > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > > Signed-off-by: Arvind Yadav > --- > drivers/mtd/devices/docg3.c | 5 - > 1 file changed, 4 insertions(+), 1

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

On 12/11/2016 07:01 PM, Arvind Yadav wrote: > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > > Signed-off-by: Arvind Yadav > --- > drivers/mtd/devices/docg3.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. Signed-off-by: Arvind Yadav --- drivers/mtd/devices/docg3.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c

[V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. Signed-off-by: Arvind Yadav --- drivers/mtd/devices/docg3.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c