Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-23 Thread Hans de Goede
Hi, On 3/19/21 5:00 AM, YingChieh, Ho wrote: > Hi Hans, > > Thank you for your kindly review. > As a beginner in driver coding, I got gains much from your suggestions. I'm glad to hear that my reviews are helping you. > Path v3 is ready at patchwork.^^ Thank you, I'll try to take a look at it

Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-18 Thread YingChieh, Ho
Hi Hans, Thank you for your kindly review. As a beginner in driver coding, I got gains much from your suggestions. Path v3 is ready at patchwork.^^ Hans de Goede 於 2021年3月19日 週五 上午12:21寫道: > > Hi, > > On 3/12/21 9:11 AM, YingChieh Ho wrote: > > From: "Andrea.Ho" > > > > Advantech sw_button is

Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-18 Thread Hans de Goede
Hi, On 3/12/21 9:11 AM, YingChieh Ho wrote: > From: "Andrea.Ho" > > Advantech sw_button is a ACPI event trigger button. > > With this driver, we can report KEY_EVENT on the > Advantech Tabletop Network Appliances products and it has been > tested in FWA1112VC. > > Add the software define

[V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-12 Thread YingChieh Ho
From: "Andrea.Ho" Advantech sw_button is a ACPI event trigger button. With this driver, we can report KEY_EVENT on the Advantech Tabletop Network Appliances products and it has been tested in FWA1112VC. Add the software define button support to report EV_REP key_event (KEY_PROG1) by pressing