Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-15 Thread Juergen Gross
On 15/09/17 15:21, Jan Beulich wrote: On 15.09.17 at 15:00, wrote: >> So I've found the data I've searched in the hypervisor. The maximum >> frame number to expect can be calculated from max_page, mem_hotplug >> and the maximum physical address from cpuid node 0x8008. If

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-15 Thread Juergen Gross
On 15/09/17 15:21, Jan Beulich wrote: On 15.09.17 at 15:00, wrote: >> So I've found the data I've searched in the hypervisor. The maximum >> frame number to expect can be calculated from max_page, mem_hotplug >> and the maximum physical address from cpuid node 0x8008. If >> CONFIG_BIGMEM

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-15 Thread Jan Beulich
>>> On 15.09.17 at 15:00, wrote: > So I've found the data I've searched in the hypervisor. The maximum > frame number to expect can be calculated from max_page, mem_hotplug > and the maximum physical address from cpuid node 0x8008. If > CONFIG_BIGMEM isn't defined in Xen it

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-15 Thread Jan Beulich
>>> On 15.09.17 at 15:00, wrote: > So I've found the data I've searched in the hypervisor. The maximum > frame number to expect can be calculated from max_page, mem_hotplug > and the maximum physical address from cpuid node 0x8008. If > CONFIG_BIGMEM isn't defined in Xen it is 16TB max. > >

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-15 Thread Juergen Gross
On 13/09/17 11:23, Juergen Gross wrote: > On 12/09/17 20:54, Andrew Cooper wrote: >> On 08/09/17 15:48, Juergen Gross wrote: >>> static void gnttab_request_version(void) >>> { >>> - int rc; >>> + long rc; >>> struct gnttab_set_version gsv; >>> >>> - gsv.version = 1; >>> + rc =

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-15 Thread Juergen Gross
On 13/09/17 11:23, Juergen Gross wrote: > On 12/09/17 20:54, Andrew Cooper wrote: >> On 08/09/17 15:48, Juergen Gross wrote: >>> static void gnttab_request_version(void) >>> { >>> - int rc; >>> + long rc; >>> struct gnttab_set_version gsv; >>> >>> - gsv.version = 1; >>> + rc =

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-13 Thread Juergen Gross
On 12/09/17 20:54, Andrew Cooper wrote: > On 08/09/17 15:48, Juergen Gross wrote: >> static void gnttab_request_version(void) >> { >> -int rc; >> +long rc; >> struct gnttab_set_version gsv; >> >> -gsv.version = 1; >> +rc = HYPERVISOR_memory_op(XENMEM_maximum_ram_page,

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-13 Thread Juergen Gross
On 12/09/17 20:54, Andrew Cooper wrote: > On 08/09/17 15:48, Juergen Gross wrote: >> static void gnttab_request_version(void) >> { >> -int rc; >> +long rc; >> struct gnttab_set_version gsv; >> >> -gsv.version = 1; >> +rc = HYPERVISOR_memory_op(XENMEM_maximum_ram_page,

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-12 Thread Andrew Cooper
On 08/09/17 15:48, Juergen Gross wrote: > static void gnttab_request_version(void) > { > - int rc; > + long rc; > struct gnttab_set_version gsv; > > - gsv.version = 1; > + rc = HYPERVISOR_memory_op(XENMEM_maximum_ram_page, NULL); This hypercall is information leak and

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-12 Thread Andrew Cooper
On 08/09/17 15:48, Juergen Gross wrote: > static void gnttab_request_version(void) > { > - int rc; > + long rc; > struct gnttab_set_version gsv; > > - gsv.version = 1; > + rc = HYPERVISOR_memory_op(XENMEM_maximum_ram_page, NULL); This hypercall is information leak and

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-12 Thread Boris Ostrovsky
On 09/08/2017 10:48 AM, Juergen Gross wrote: > Based on the maximum page number of the host select either grant v1 or > grant v2. > > For testing purposes add a way to specify the grant interface version > via a boot parameter. > > Signed-off-by: Juergen Gross Reviewed-by: Boris

Re: [Xen-devel] [PATCH 4/4] xen: select grant interface version

2017-09-12 Thread Boris Ostrovsky
On 09/08/2017 10:48 AM, Juergen Gross wrote: > Based on the maximum page number of the host select either grant v1 or > grant v2. > > For testing purposes add a way to specify the grant interface version > via a boot parameter. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky