Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-20 Thread Vinod
On 20-06-18, 10:53, Srinivas Kandagatla wrote: > On 20/06/18 10:31, Vinod wrote: > > > Here clock will be enabled twice but disable will be called only once when > > > count = 0. > > > > > > This will make the clock always enabled. So, I think we should keep either > > > mutex lock or atomic varia

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-20 Thread Srinivas Kandagatla
On 20/06/18 10:31, Vinod wrote: Here clock will be enabled twice but disable will be called only once when count = 0. This will make the clock always enabled. So, I think we should keep either mutex lock or atomic variable to synchronize this. we are using DPCM here right? We should probab

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-20 Thread Vinod
Hi Rohit, On 20-06-18, 13:07, Rohit Kumar wrote: > > On 19-06-18, 19:20, Rohit Kumar wrote: > > > On 6/19/2018 10:35 AM, Vinod wrote: > > > > On 18-06-18, 16:46, Rohit kumar wrote: > > > > > > > > > +struct sdm845_snd_data { > > > > > + struct snd_soc_card *card; > > > > > + struct regula

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Vinod
Hi Rohit, On 19-06-18, 19:20, Rohit Kumar wrote: > On 6/19/2018 10:35 AM, Vinod wrote: > > On 18-06-18, 16:46, Rohit kumar wrote: > > > > > +struct sdm845_snd_data { > > > + struct snd_soc_card *card; > > > + struct regulator *vdd_supply; > > > + struct snd_soc_dai_link dai_link[]; > > > +}; > >

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Rohit Kumar
Thanks Srinivas for reviewing. On 6/19/2018 2:16 PM, Srinivas Kandagatla wrote: Thanks Rohit for the patch! On 18/06/18 12:16, Rohit kumar wrote: This patch adds sdm845 audio machine driver support. Signed-off-by: Rohit kumar ---   .../devicetree/bindings/sound/qcom,sdm845.txt  |  87 ++

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Rohit Kumar
Thanks Vinod for reviewing. On 6/19/2018 10:35 AM, Vinod wrote: On 18-06-18, 16:46, Rohit kumar wrote: +struct sdm845_snd_data { + struct snd_soc_card *card; + struct regulator *vdd_supply; + struct snd_soc_dai_link dai_link[]; +}; + +static struct mutex pri_mi2s_res_lock; +

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-18 Thread Vinod
On 18-06-18, 16:46, Rohit kumar wrote: > +struct sdm845_snd_data { > + struct snd_soc_card *card; > + struct regulator *vdd_supply; > + struct snd_soc_dai_link dai_link[]; > +}; > + > +static struct mutex pri_mi2s_res_lock; > +static struct mutex quat_tdm_res_lock; any reason why the