Re: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-13 Thread Mark Brown
On Mon, Jan 13, 2014 at 09:09:43AM +, li.xi...@freescale.com wrote: > @Mark, Since what Jean-Francios is concerned by is another issue apart from > this patch itself and being discussed, can you apply the patch? I thought I'd already applied it but if I didn't you'll need to resend.

RE: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-13 Thread li.xi...@freescale.com
Hi Mark, Jean-Francios > If the original cinfo is not used anymore, the use of its structure to > handle the card information is not a good idea: > > - almost all cinfo information are in the struct snd_soc_card, > > - this cinfo structure cannot be extended to handle many DAI links, > > - it

RE: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-13 Thread li.xi...@freescale.com
Hi Mark, Jean-Francios If the original cinfo is not used anymore, the use of its structure to handle the card information is not a good idea: - almost all cinfo information are in the struct snd_soc_card, - this cinfo structure cannot be extended to handle many DAI links, - it contains

Re: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-13 Thread Mark Brown
On Mon, Jan 13, 2014 at 09:09:43AM +, li.xi...@freescale.com wrote: @Mark, Since what Jean-Francios is concerned by is another issue apart from this patch itself and being discussed, can you apply the patch? I thought I'd already applied it but if I didn't you'll need to resend.

RE: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-12 Thread li.xi...@freescale.com
Hi Jean-Francois, > > If the original cinfo is not used anymore, the use of its structure to > handle the card information is not a good idea: > > - almost all cinfo information are in the struct snd_soc_card, > > - this cinfo structure cannot be extended to handle many DAI links, > > - it

RE: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-12 Thread li.xi...@freescale.com
Hi Jean-Francois, If the original cinfo is not used anymore, the use of its structure to handle the card information is not a good idea: - almost all cinfo information are in the struct snd_soc_card, - this cinfo structure cannot be extended to handle many DAI links, - it contains

Re: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-09 Thread Jean-Francois Moine
Xiubo Li wrote: > It's a bug that writing to the platform data directly, for it should > be constant. So just copy it before writing. > > Signed-off-by: Xiubo Li > --- > sound/soc/generic/simple-card.c | 40 +--- > 1 file changed, 21 insertions(+), 19

Re: [alsa-devel] [PATCH] ASoC: simple-card: fix one bug to writing to the platform data

2014-01-09 Thread Jean-Francois Moine
Xiubo Li wrote: It's a bug that writing to the platform data directly, for it should be constant. So just copy it before writing. Signed-off-by: Xiubo Li Li.Xiubo at freescale.com --- sound/soc/generic/simple-card.c | 40 +--- 1 file changed, 21