Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-16 Thread Mark Brown
On Tue, Jul 14, 2015 at 02:47:04PM +0200, Tomeu Vizoso wrote: > On 14 July 2015 at 13:07, Mark Brown wrote: > > I'm not sure how I can be clearer here... you're replacing something > > that is currently pure data with open coding in each device. That seems > > like a step back in terms of ease

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-16 Thread Mark Brown
On Tue, Jul 14, 2015 at 02:47:04PM +0200, Tomeu Vizoso wrote: On 14 July 2015 at 13:07, Mark Brown broo...@kernel.org wrote: I'm not sure how I can be clearer here... you're replacing something that is currently pure data with open coding in each device. That seems like a step back in

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-14 Thread Tomeu Vizoso
On 14 July 2015 at 13:07, Mark Brown wrote: > On Tue, Jul 14, 2015 at 09:34:22AM +0200, Tomeu Vizoso wrote: >> On 13 July 2015 at 17:42, Mark Brown wrote: > >> > No, I'm looking at how we already have all the "did all my dependencies >> > appear" logic in the core based on data provided by the

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-14 Thread Mark Brown
On Tue, Jul 14, 2015 at 09:34:22AM +0200, Tomeu Vizoso wrote: > On 13 July 2015 at 17:42, Mark Brown wrote: > > No, I'm looking at how we already have all the "did all my dependencies > > appear" logic in the core based on data provided by the drivers. > Sorry, but I still don't get what you

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-14 Thread Tomeu Vizoso
On 13 July 2015 at 17:42, Mark Brown wrote: > On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: >> On 1 July 2015 at 19:38, Mark Brown wrote: >> > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > >> >> +static void tegra_max98090_get_dependencies(struct fwnode_handle

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-14 Thread Tomeu Vizoso
On 13 July 2015 at 17:42, Mark Brown broo...@kernel.org wrote: On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: On 1 July 2015 at 19:38, Mark Brown broo...@kernel.org wrote: On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: +static void

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-14 Thread Mark Brown
On Tue, Jul 14, 2015 at 09:34:22AM +0200, Tomeu Vizoso wrote: On 13 July 2015 at 17:42, Mark Brown broo...@kernel.org wrote: No, I'm looking at how we already have all the did all my dependencies appear logic in the core based on data provided by the drivers. Sorry, but I still don't get

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-14 Thread Tomeu Vizoso
On 14 July 2015 at 13:07, Mark Brown broo...@kernel.org wrote: On Tue, Jul 14, 2015 at 09:34:22AM +0200, Tomeu Vizoso wrote: On 13 July 2015 at 17:42, Mark Brown broo...@kernel.org wrote: No, I'm looking at how we already have all the did all my dependencies appear logic in the core based

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-13 Thread Mark Brown
On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: > On 1 July 2015 at 19:38, Mark Brown wrote: > > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, > >> +

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-13 Thread Tomeu Vizoso
On 1 July 2015 at 19:38, Mark Brown wrote: > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, >> + struct list_head *deps) >> +{ >> + add_dependency(fwnode,

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-13 Thread Tomeu Vizoso
On 1 July 2015 at 19:38, Mark Brown broo...@kernel.org wrote: On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, + struct list_head *deps) +{ +

Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

2015-07-13 Thread Mark Brown
On Mon, Jul 13, 2015 at 02:10:45PM +0200, Tomeu Vizoso wrote: On 1 July 2015 at 19:38, Mark Brown broo...@kernel.org wrote: On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, +