Re: [alsa-devel] [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support

2018-06-22 Thread Srinivas Kandagatla
On 22/06/18 11:36, Rohit Kumar wrote: Sure, I will add a new file, qcom_snd_common.c, which will have these common functions and will update apq8096 and sdm845 machine driver to use APIs exposed by qcom_snd_common.c Just name it as "common.c" no need to prefix this as is going to live in s

Re: [alsa-devel] [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support

2018-06-22 Thread Rohit Kumar
On 6/21/2018 8:39 PM, Srinivas Kandagatla wrote: On 21/06/18 13:35, Vinod wrote: And this one is generic DT parsing and seems quite similar to one in apq8096.c Can we move these into a lib and use them instead of duplicating. I totally agree with Vinod, We should probably come up with a li

Re: [alsa-devel] [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support

2018-06-21 Thread Srinivas Kandagatla
On 21/06/18 13:35, Vinod wrote: And this one is generic DT parsing and seems quite similar to one in apq8096.c Can we move these into a lib and use them instead of duplicating. I totally agree with Vinod, We should probably come up with a library functions something like common.c so that we d

Re: [alsa-devel] [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support

2018-06-21 Thread Vinod
Hi Rohit, On 21-06-18, 16:23, Rohit kumar wrote: > +static struct sdm845_snd_data *sdm845_sbc_parse_of(struct snd_soc_card *card) > +{ > + struct device *dev = card->dev; > + struct snd_soc_dai_link *link; > + struct device_node *np, *codec, *platform, *cpu, *node; > + int ret, nu