Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 04:19:56PM +0100, Russell King - ARM Linux wrote: > On Tue, Jul 23, 2013 at 04:01:50PM +0100, Mark Brown wrote: > > Why would platform data have anything to do with this? To repeat again > > the way the clocks are mapped should be totally transparent to the > > driver requ

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 02:50:00PM +0100, Russell King - ARM Linux wrote: > Not only that, but the lack of assistance from ASoC people on the > multiple substream stuff really doesn't help one iota when it comes to > making forward progress with SPDIF support. I've explained to them the It'd pro

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Jean-Francois Moine
On Tue, 23 Jul 2013 15:30:57 +0200 Sebastian Hesselbarth wrote: > >> again, we mentioned to merge kirkwood-i2s.c and kirkwood-dma.c into > >> a single file, didn't we? > > > > That's been discussed several times but nobody's actually done it. > > Correct, that is why I repeated that request

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Russell King - ARM Linux
On Tue, Jul 23, 2013 at 04:01:50PM +0100, Mark Brown wrote: > On Tue, Jul 23, 2013 at 03:30:57PM +0200, Sebastian Hesselbarth wrote: > > On 07/23/13 15:20, Mark Brown wrote: > > > >Why would this be required? The driver is already asking for multiple > > >clocks... > > > The driver is asking for

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 03:30:57PM +0200, Sebastian Hesselbarth wrote: > On 07/23/13 15:20, Mark Brown wrote: > >Why would this be required? The driver is already asking for multiple > >clocks... > The driver is asking for multiple *DT based* clocks. Legacy > platform_data has never been updated

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Russell King - ARM Linux
On Tue, Jul 23, 2013 at 03:30:57PM +0200, Sebastian Hesselbarth wrote: > On 07/23/13 15:20, Mark Brown wrote: >>> again, we mentioned to merge kirkwood-i2s.c and kirkwood-dma.c into >>> a single file, didn't we? >> >> That's been discussed several times but nobody's actually done it. > > Correct, t

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Sebastian Hesselbarth
On 07/23/13 15:20, Mark Brown wrote: On Tue, Jul 23, 2013 at 02:59:06PM +0200, Sebastian Hesselbarth wrote: On 07/23/13 14:34, Mark Brown wrote: As others have pointed out if you need to change the clock get code there's something wrong here, DT should be handled transparently by the clock AP

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 02:59:06PM +0200, Sebastian Hesselbarth wrote: > On 07/23/13 14:34, Mark Brown wrote: > >As others have pointed out if you need to change the clock get code > >there's something wrong here, DT should be handled transparently by the > >clock API. > IMHO the reason why of_cl

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Sebastian Hesselbarth
On 07/23/13 14:34, Mark Brown wrote: On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote: + np = pdev->dev.of_node; + if (np) { + struct of_phandle_args clkspec; + + priv->burst = 128; /* might be 32 or 128 */ The comme

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Sascha Hauer
On Tue, Jul 23, 2013 at 10:39:50AM +0100, Russell King - ARM Linux wrote: > On Tue, Jul 23, 2013 at 11:08:20AM +0200, Sascha Hauer wrote: > > On Tue, Jul 23, 2013 at 09:53:46AM +0100, Russell King - ARM Linux wrote: > > > On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote: > > > >

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Russell King - ARM Linux
On Tue, Jul 23, 2013 at 11:08:20AM +0200, Sascha Hauer wrote: > On Tue, Jul 23, 2013 at 09:53:46AM +0100, Russell King - ARM Linux wrote: > > On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote: > > > The kirkwood i2s driver is used without DT in the Kirkwood machine. > > > This pat

Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

2013-07-23 Thread Sascha Hauer
On Tue, Jul 23, 2013 at 09:53:46AM +0100, Russell King - ARM Linux wrote: > On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote: > > The kirkwood i2s driver is used without DT in the Kirkwood machine. > > This patch adds a DT compatible definition for use in other Marvell > > machin