Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Pierre-Louis Bossart
On 4/30/19 9:54 AM, Vfiinod Koul wrote: On 30-04-19, 08:38, Pierre-Louis Bossart wrote: On 4/30/19 3:51 AM, Vinod Koul wrote: On 15-04-19, 08:09, Pierre-Louis Bossart wrote: Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/Kconfig | 2 +-

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Greg KH
On Tue, Apr 30, 2019 at 09:13:55AM -0500, Pierre-Louis Bossart wrote: > > > My patch-bot would reject a patch that tried to do multiple types of > > different cleanups on the same file(s). Has done so for _years_, this > > is not a new thing. > > If there are tools let's use them (all the fixes

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Pierre-Louis Bossart
My patch-bot would reject a patch that tried to do multiple types of different cleanups on the same file(s). Has done so for _years_, this is not a new thing. If there are tools let's use them (all the fixes in this series were reported by tools). Can you share pointers and location of

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Greg KH
On Tue, Apr 30, 2019 at 08:38:01AM -0500, Pierre-Louis Bossart wrote: > On 4/30/19 3:51 AM, Vinod Koul wrote: > > On 15-04-19, 08:09, Pierre-Louis Bossart wrote: > > > > > > > > > > > > > Signed-off-by: Pierre-Louis Bossart > > > > > > > > > > --- > > > > >drivers/soundwire/Kconfig

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Pierre-Louis Bossart
On 4/30/19 3:51 AM, Vinod Koul wrote: On 15-04-19, 08:09, Pierre-Louis Bossart wrote: Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c| 87 drivers/soundwire/bus.h| 16 +--

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Vinod Koul
On 19-04-19, 12:14, Pierre-Louis Bossart wrote: > > > > >   enum sdw_command_response > > > >   cdns_xfer_msg_defer(struct sdw_bus *bus, > > > > -    struct sdw_msg *msg, struct sdw_defer *defer) > > > > +    struct sdw_msg *msg, struct sdw_defer *defer) > > > > > > this one too.. >

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Vinod Koul
On 15-04-19, 08:09, Pierre-Louis Bossart wrote: > > > > > > > Signed-off-by: Pierre-Louis Bossart > > > --- > > > drivers/soundwire/Kconfig | 2 +- > > > drivers/soundwire/bus.c| 87 > > > drivers/soundwire/bus.h| 16 +-- > > >

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-19 Thread Pierre-Louis Bossart
  enum sdw_command_response   cdns_xfer_msg_defer(struct sdw_bus *bus, -    struct sdw_msg *msg, struct sdw_defer *defer) +    struct sdw_msg *msg, struct sdw_defer *defer) this one too..   static int cdns_port_params(struct sdw_bus *bus, -    struct sdw_port_params

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-18 Thread Johan Hovold
On Wed, Apr 17, 2019 at 12:18:22PM -0500, Pierre-Louis Bossart wrote: > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig > index 19c8efb9a5ee..84876a74874f 100644 > --- a/drivers/soundwire/Kconfig > +++ b/drivers/soundwire/Kconfig > @@ -4,7 +4,7 @@ >

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-17 Thread Pierre-Louis Bossart
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig index 19c8efb9a5ee..84876a74874f 100644 --- a/drivers/soundwire/Kconfig +++ b/drivers/soundwire/Kconfig @@ -4,7 +4,7 @@ menuconfig SOUNDWIRE bool "SoundWire support" - ---help--- + help Not sure if

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-17 Thread Johan Hovold
On Mon, Apr 15, 2019 at 08:09:59AM -0500, Pierre-Louis Bossart wrote: > > >> > >> Signed-off-by: Pierre-Louis Bossart > >> --- > >> drivers/soundwire/Kconfig | 2 +- > >> drivers/soundwire/bus.c| 87 > >> drivers/soundwire/bus.h| 16 +-- >

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-15 Thread Pierre-Louis Bossart
Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c| 87 drivers/soundwire/bus.h| 16 +-- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 87