Re: [blk] WARNING: CPU: 0 PID: 300 at kernel/softirq.c:156 _local_bh_enable_ip()

2014-04-23 Thread Hong zhi guo
Hi, I think one fix is to use "_local_bh_enable()" instead of "local_bh_enable()" in u64_stats_fetch_retry_bh(). There's no enabling of irq in _local_bh_enable(). But I wonder why we do "WARN_ON_ONCE(!irqs_disabled() )" in _local_bh_enable()? What's the bad thing if someone call

Re: [blk] WARNING: CPU: 0 PID: 300 at kernel/softirq.c:156 _local_bh_enable_ip()

2014-04-23 Thread Hong zhi guo
Hi, I think one fix is to use _local_bh_enable() instead of local_bh_enable() in u64_stats_fetch_retry_bh(). There's no enabling of irq in _local_bh_enable(). But I wonder why we do WARN_ON_ONCE(!irqs_disabled() ) in _local_bh_enable()? What's the bad thing if someone call _local_bh_enable()

Re: [blk] WARNING: CPU: 0 PID: 300 at kernel/softirq.c:156 _local_bh_enable_ip()

2014-04-21 Thread Jens Axboe
On 2014-04-20 14:30, Jet Chen wrote: Hi Zhiguo, I got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 2c575026fae6e63771bd2a4c1d407214a8096a89 Author: Hong Zhiguo AuthorDate: Wed Nov 20 10:35:05 2013 -0700 Commit:

Re: [blk] WARNING: CPU: 0 PID: 300 at kernel/softirq.c:156 _local_bh_enable_ip()

2014-04-21 Thread Jens Axboe
On 2014-04-20 14:30, Jet Chen wrote: Hi Zhiguo, I got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 2c575026fae6e63771bd2a4c1d407214a8096a89 Author: Hong Zhiguo zhiguoh...@tencent.com AuthorDate: Wed Nov 20