Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Samuel Ortiz
On Mon, Feb 11, 2013 at 08:03:46AM -0800, Greg KH wrote: > On Mon, Feb 11, 2013 at 04:29:29PM +0100, Samuel Ortiz wrote: > > Hi Arnd, > > > > On Mon, Feb 11, 2013 at 02:58:37PM +, Arnd Bergmann wrote: > > > On Thursday 07 February 2013, Samuel Ortiz wrote: > > > > > > > > On Thu, Feb 07,

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Greg KH
On Mon, Feb 11, 2013 at 04:29:29PM +0100, Samuel Ortiz wrote: > Hi Arnd, > > On Mon, Feb 11, 2013 at 02:58:37PM +, Arnd Bergmann wrote: > > On Thursday 07 February 2013, Samuel Ortiz wrote: > > > > > > On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: > > > > On Thu, Feb 07, 2013

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Samuel Ortiz
Hi Arnd, On Mon, Feb 11, 2013 at 02:58:37PM +, Arnd Bergmann wrote: > On Thursday 07 February 2013, Samuel Ortiz wrote: > > > > On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: > > > On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: > > > > On Thursday 07 February

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Arnd Bergmann
On Thursday 07 February 2013, Samuel Ortiz wrote: > > On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: > > On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: > > > On Thursday 07 February 2013, Tomas Winkler wrote: > > > > > > > > +inline void

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Arnd Bergmann
On Thursday 07 February 2013, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Tomas Winkler wrote: +inline void *mei_bus_get_clientdata(const struct

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Samuel Ortiz
Hi Arnd, On Mon, Feb 11, 2013 at 02:58:37PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Tomas

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Greg KH
On Mon, Feb 11, 2013 at 04:29:29PM +0100, Samuel Ortiz wrote: Hi Arnd, On Mon, Feb 11, 2013 at 02:58:37PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 10:38:44PM

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-11 Thread Samuel Ortiz
On Mon, Feb 11, 2013 at 08:03:46AM -0800, Greg KH wrote: On Mon, Feb 11, 2013 at 04:29:29PM +0100, Samuel Ortiz wrote: Hi Arnd, On Mon, Feb 11, 2013 at 02:58:37PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 11:58:09PM

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Samuel Ortiz
On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: > On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: > > On Thursday 07 February 2013, Tomas Winkler wrote: > > > > > > +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) > > > +{ > > > + return

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Samuel Ortiz
On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: > On Thursday 07 February 2013, Tomas Winkler wrote: > > > > +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) > > +{ > > + return dev_get_drvdata(>dev); > > +} > > +EXPORT_SYMBOL(mei_bus_get_clientdata);

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: > > +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) > +{ > + return dev_get_drvdata(>dev); > +} > +EXPORT_SYMBOL(mei_bus_get_clientdata); > + Did you really mean to export an inline function? Can you make this a

[char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Tomas Winkler
From: Samuel Ortiz MEI bus drivers should be able to carry their private data around. Signed-off-by: Samuel Ortiz Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 12 include/linux/mei_bus.h |3 +++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git

[char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Tomas Winkler
From: Samuel Ortiz sa...@linux.intel.com MEI bus drivers should be able to carry their private data around. Signed-off-by: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Tomas Winkler tomas.wink...@intel.com --- drivers/misc/mei/bus.c | 12 include/linux/mei_bus.h |3 +++

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) +{ + return dev_get_drvdata(client-dev); +} +EXPORT_SYMBOL(mei_bus_get_clientdata); + Did you really mean to export an inline function? Can you make this a

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Samuel Ortiz
On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Tomas Winkler wrote: +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) +{ + return dev_get_drvdata(client-dev); +} +EXPORT_SYMBOL(mei_bus_get_clientdata); +

Re: [char-misc-next 07/11] mei: bus: Implement bus driver data setter/getter

2013-02-07 Thread Samuel Ortiz
On Thu, Feb 07, 2013 at 11:58:09PM +0100, Samuel Ortiz wrote: On Thu, Feb 07, 2013 at 10:38:44PM +, Arnd Bergmann wrote: On Thursday 07 February 2013, Tomas Winkler wrote: +inline void *mei_bus_get_clientdata(const struct mei_bus_client *client) +{ + return